Gentoo Archives: gentoo-dev

From: "Michał Górny" <mgorny@g.o>
To: gentoo-dev@l.g.o
Cc: "Michał Górny" <mgorny@g.o>
Subject: [gentoo-dev] [PATCH 1/5] media-plugins/vdr-live: Replace unnecessary path_exists calls
Date: Thu, 09 Aug 2018 02:21:04
Message-Id: 20180808213418.28823-1-mgorny@gentoo.org
1 Replace the unnecessary path_exists calls with plain bash -f test.
2 The path_exists function was only intended to be used when necessary
3 to deal with wildcards.
4
5 Bug: https://bugs.gentoo.org/662178
6 ---
7 media-plugins/vdr-live/vdr-live-0.3.0_p20130504-r1.ebuild | 2 +-
8 media-plugins/vdr-live/vdr-live-0.3.0_p20130504-r2.ebuild | 2 +-
9 media-plugins/vdr-live/vdr-live-2.3.1.ebuild | 2 +-
10 3 files changed, 3 insertions(+), 3 deletions(-)
11
12 diff --git a/media-plugins/vdr-live/vdr-live-0.3.0_p20130504-r1.ebuild b/media-plugins/vdr-live/vdr-live-0.3.0_p20130504-r1.ebuild
13 index 6041faafd99e..24ec6897b14f 100644
14 --- a/media-plugins/vdr-live/vdr-live-0.3.0_p20130504-r1.ebuild
15 +++ b/media-plugins/vdr-live/vdr-live-0.3.0_p20130504-r1.ebuild
16 @@ -90,7 +90,7 @@ pkg_postinst() {
17 elog "\tadmin:live"
18
19 if use ssl ; then
20 - if path_exists -a "${ROOT}"/etc/vdr/plugins/live/live.pem; then
21 + if [[ -f ${ROOT}/etc/vdr/plugins/live/live.pem ]]; then
22 einfo "found an existing SSL cert, to create a new SSL cert, run:\n"
23 einfo "emerge --config ${PN}"
24 else
25 diff --git a/media-plugins/vdr-live/vdr-live-0.3.0_p20130504-r2.ebuild b/media-plugins/vdr-live/vdr-live-0.3.0_p20130504-r2.ebuild
26 index 0dbcc0a04730..9ecf777aa274 100644
27 --- a/media-plugins/vdr-live/vdr-live-0.3.0_p20130504-r2.ebuild
28 +++ b/media-plugins/vdr-live/vdr-live-0.3.0_p20130504-r2.ebuild
29 @@ -93,7 +93,7 @@ pkg_postinst() {
30 elog "\tadmin:live"
31
32 if use ssl ; then
33 - if path_exists -a "${ROOT}"/etc/vdr/plugins/live/live.pem; then
34 + if [[ -f ${ROOT}/etc/vdr/plugins/live/live.pem ]]; then
35 einfo "found an existing SSL cert, to create a new SSL cert, run:\n"
36 einfo "emerge --config ${PN}"
37 else
38 diff --git a/media-plugins/vdr-live/vdr-live-2.3.1.ebuild b/media-plugins/vdr-live/vdr-live-2.3.1.ebuild
39 index f46cff93c6de..6a0ea6d24b88 100644
40 --- a/media-plugins/vdr-live/vdr-live-2.3.1.ebuild
41 +++ b/media-plugins/vdr-live/vdr-live-2.3.1.ebuild
42 @@ -86,7 +86,7 @@ pkg_postinst() {
43 elog "\tadmin:live"
44
45 if use ssl ; then
46 - if path_exists -a "${ROOT}"/etc/vdr/plugins/live/live.pem; then
47 + if [[ -f ${ROOT}/etc/vdr/plugins/live/live.pem ]]; then
48 einfo "found an existing SSL cert, to create a new SSL cert, run:\n"
49 einfo "emerge --config ${PN}"
50 else
51 --
52 2.18.0

Replies