Gentoo Archives: gentoo-dev

From: "Michał Górny" <mgorny@g.o>
To: gentoo-dev@l.g.o, Andrew Savchenko <bircoph@g.o>
Subject: Re: [gentoo-dev] [PATCH] Add section about defining "Test Dependencies"
Date: Sun, 26 Aug 2018 08:08:42
Message-Id: 1535270912.1066.12.camel@gentoo.org
In Reply to: Re: [gentoo-dev] [PATCH] Add section about defining "Test Dependencies" by Zac Medico
1 On Sun, 2018-08-26 at 00:58 -0700, Zac Medico wrote:
2 > On 08/26/2018 12:39 AM, Michał Górny wrote:
3 > > On Sun, 2018-08-26 at 00:28 -0700, Zac Medico wrote:
4 > > > On 08/25/2018 07:11 PM, Andrew Savchenko wrote:
5 > > > > On Sat, 25 Aug 2018 14:24:02 -0400 Mike Gilbert wrote:
6 > > > > > On Sat, Aug 25, 2018 at 1:41 AM Andrew Savchenko <bircoph@g.o> wrote:
7 > > > > > >
8 > > > > > > On Fri, 24 Aug 2018 14:24:06 -0400 Mike Gilbert wrote:
9 > > > > > > > ---
10 > > > > > > > general-concepts/dependencies/text.xml | 38 ++++++++++++++++++++++++++
11 > > > > > > > 1 file changed, 38 insertions(+)
12 > > > > > > >
13 > > > > > > > diff --git a/general-concepts/dependencies/text.xml b/general-concepts/dependencies/text.xml
14 > > > > > > > index 2f10380..64be9dc 100644
15 > > > > > > > --- a/general-concepts/dependencies/text.xml
16 > > > > > > > +++ b/general-concepts/dependencies/text.xml
17 > > > > > > > @@ -578,6 +578,44 @@ valid.
18 > > > > > > > </body>
19 > > > > > > > </section>
20 > > > > > > >
21 > > > > > > > +<section>
22 > > > > > > > +<title>Test Dependencies</title>
23 > > > > > > > +<body>
24 > > > > > > > +
25 > > > > > > > +<p>
26 > > > > > > > +Packages often have optional dependencies that are needed only when running
27 > > > > > > > +tests. These should be specified in DEPEND behind a USE flag. Often, the
28 > > > > > > > +'test' USE flag is used for this purpose.
29 > > > > > > > +</p>
30 > > > > > > > +
31 > > > > > > > +<p>
32 > > > > > > > +Since testing will likely fail when test dependencies are not installed, the
33 > > > > > > > +test phase should be disabled in this case. This may be accomplished via USE
34 > > > > > > > +conditionals in the RESTRICT variable.
35 > > > > > > > +</p>
36 > > > > > > > +
37 > > > > > > > +<p>
38 > > > > > > > +If other optional features must be enabled/disabled when testing, REQUIRED_USE
39 > > > > > > > +may be set to express this.
40 > > > > > > > +</p>
41 > > > > > > > +
42 > > > > > > > +<codesample lang="ebuild">
43 > > > > > > > +# Define some USE flags
44 > > > > > > > +IUSE="debug test"
45 > > > > > > > +
46 > > > > > > > +# Disable test phase when test USE flag is disabled
47 > > > > > > > +RESTRICT="!test? ( test )"
48 > > > > > >
49 > > > > > > I do not understand why we need this useless code. If test USE flag
50 > > > > > > is disabled, tests must be disabled as well. It is PM's job and
51 > > > > > > there is no need to put this obvious stuff into each ebuild with
52 > > > > > > tests and extra deps. I see no reason to support running src_test()
53 > > > > > > with USE="-test".
54 > > > > >
55 > > > > > PMS does not specify that behavior (skipping src_test with USE=-test).
56 > > > > > It is better to define the requrement explicitly rather than relying
57 > > > > > on a Portage-specific behavior.
58 > > > >
59 > > > > Then PMS should be fixed. Putting useless code in thousands
60 > > > > of ebuilds due to bureaucratic reasons is ridiculous. Having strict
61 > > > > conformance to the PMS is good, but common sense should still be
62 > > > > considered.
63 > > >
64 > > > Since PMS doesn't specify the behavior of FEATURES, I suppose we could
65 > > > make FEATURES=test imply RESTRICT="!test? ( test )". Would there be any
66 > > > drawbacks to that?
67 > >
68 > > Except for Portage once again silently letting developers pass with non-
69 > > PMS behavior, and making other PMs fail with the ebuilds?
70 >
71 > Is it really sane for other PMs to behave that way though?
72 >
73 > In PMS it says src_test "may be disabled by user too, using a
74 > PM-specific mechanism", which doesn't explicitly rule out behavior based
75 > on USE settings.
76
77 It doesn't rule out disabling based on the phase of the moon either, or
78 my mood which is degrading badly with this discussion.
79
80 --
81 Best regards,
82 Michał Górny

Attachments

File name MIME type
signature.asc application/pgp-signature

Replies