1 |
>>>>> On Sun, 20 Oct 2019, David Seifert wrote: |
2 |
|
3 |
> - if [[ -e fonts.alias ]]; then |
4 |
> - doins fonts.alias || die "failed to install fonts.alias" # TODO old EAPI cleanup |
5 |
> - fi |
6 |
> + [[ -e fonts.alias ]] && doins fonts.alias |
7 |
> fi |
8 |
> } |
9 |
|
10 |
Is the function's return value of any importance? The function will now |
11 |
return shell false if fonts.alias doesn't exist, while previously it |
12 |
returned true. |
13 |
|
14 |
> - [[ -n ${DOCS} ]] && { dodoc ${DOCS} || die "docs installation failed" ; } # TODO old EAPI cleanup |
15 |
> + einstalldocs |
16 |
|
17 |
> # install common docs |
18 |
> - for commondoc in COPYRIGHT README{,.md,.txt} NEWS AUTHORS BUGS ChangeLog FONTLOG.txt; do |
19 |
> + for commondoc in COPYRIGHT FONTLOG.txt; do |
20 |
> [[ -s ${commondoc} ]] && dodoc ${commondoc} |
21 |
> done |
22 |
|
23 |
This changes the set of installed files, if the DOCS variable is |
24 |
defined. Is that intentional? |
25 |
|
26 |
> - if [[ -e "${EROOT%/}"/etc/fonts/conf.avail/${conffile##*/} ]]; then |
27 |
> - elog " ${conffile##*/}" |
28 |
> - fi |
29 |
> + [[ -e "${EROOT%/}"/etc/fonts/conf.avail/${conffile##*/} ]] && elog " ${conffile##*/}" |
30 |
|
31 |
This doesn't change any functionality, but it adds an overlong line for |
32 |
no good reason. |
33 |
|
34 |
Ulrich |