Gentoo Archives: gentoo-dev

From: Mike Pagano <mpagano@g.o>
To: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] [PATCH 1/1] kernel-2.eclass: Support EAPI 6 when applying user patches.
Date: Mon, 28 Nov 2016 11:42:58
Message-Id: 1a7fdc22-ff3d-6627-dae6-83178e868cbb@gentoo.org
In Reply to: Re: [gentoo-dev] [PATCH 1/1] kernel-2.eclass: Support EAPI 6 when applying user patches. by Mike Gilbert
1 On 11/27/2016 09:06 PM, Mike Gilbert wrote:
2 > On Sun, Nov 27, 2016 at 7:23 PM, Mike Pagano <mpagano@g.o> wrote:
3 >> If kernel-2_src_unpack() is called in EAPI6, epatch_user() function
4 >> inherited from eutils.eclass is undefined.
5 >> See bug #579188
6 >
7 > kernel-2.eclass currently calls die in global scope for EAPI 6, so
8 > this change has no real effect.
9 >
10 > I would suggest modernizing the eclass before allowing it to be used
11 > with EAPI 6. For example, patches should be applied in src_prepare,
12 > not src_unpack.
13 >
14
15
16 Is this change not a step in the right direction? Or should it just be
17 one big bang?
18 All or nothing?
19
20 --
21 Mike Pagano
22 Gentoo Developer - Kernel Project
23 Gentoo Sources - Lead
24 E-Mail : mpagano@g.o
25 GnuPG FP : 52CC A0B0 F631 0B17 0142 F83F 92A6 DBEC 81F2 B137
26 Public Key :
27 http://http://pgp.mit.edu/pks/lookup?search=0x92A6DBEC81F2B137&op=index

Attachments

File name MIME type
signature.asc application/pgp-signature

Replies