| 1 |
On 06/19/2017 06:20 AM, Michał Górny wrote: |
| 2 |
> The GNOME team has committed the xdg-utils.eclass serving exactly |
| 3 |
> the same purpose as fdo-mime.eclass, supposedly with the goal of |
| 4 |
> replacing it. However, it seems that they have never bothered to |
| 5 |
> actually hint the deprecation in the fdo-mime.eclass in any way. |
| 6 |
> As a result, developers are still adding references to this eclass |
| 7 |
> instead of using xdg-utils or xdg, and/or not working towards replacing |
| 8 |
> them. |
| 9 |
> |
| 10 |
> Add an explicit deprecation notice to the fdo-mime.eclass to make it |
| 11 |
> clear that the eclass should not be used in new packages, and what |
| 12 |
> the replacement eclasses are. |
| 13 |
> --- |
| 14 |
> eclass/fdo-mime.eclass | 4 +++- |
| 15 |
> 1 file changed, 3 insertions(+), 1 deletion(-) |
| 16 |
> |
| 17 |
> diff --git a/eclass/fdo-mime.eclass b/eclass/fdo-mime.eclass |
| 18 |
> index b3b096d154e7..8e51d8a69df1 100644 |
| 19 |
> --- a/eclass/fdo-mime.eclass |
| 20 |
> +++ b/eclass/fdo-mime.eclass |
| 21 |
> @@ -1,4 +1,4 @@ |
| 22 |
> -# Copyright 1999-2011 Gentoo Foundation |
| 23 |
> +# Copyright 1999-2017 Gentoo Foundation |
| 24 |
> # Distributed under the terms of the GNU General Public License v2 |
| 25 |
> |
| 26 |
> # @ECLASS: fdo-mime.eclass |
| 27 |
> @@ -7,6 +7,8 @@ |
| 28 |
> # @AUTHOR: |
| 29 |
> # Original author: foser <foser@g.o> |
| 30 |
> # @BLURB: Utility eclass to update the desktop mime info as laid out in the freedesktop specs & implementations |
| 31 |
> +# @DESCRIPTION: |
| 32 |
> +# This eclass is DEPRECATED. Please use xdg-utils or xdg instead. |
| 33 |
> |
| 34 |
> # @FUNCTION: fdo-mime_desktop_database_update |
| 35 |
> # @DESCRIPTION: |
| 36 |
> |
| 37 |
Looks good to me. Thanks for looking out for stuff like this. |
| 38 |
|
| 39 |
That aside, isn't this supposed to be standard operating procedure if a |
| 40 |
developer is deprecating an eclass? And similarly with the removal of an |
| 41 |
eclass, all ebuilds getting updated by the developer or team that |
| 42 |
prompted the removal of the eclass? |
| 43 |
|
| 44 |
My apologies if this is answered elsewhere. I want to be sure what's |
| 45 |
expected, just in case I need to touch an eclass. |
| 46 |
|
| 47 |
-- |
| 48 |
Daniel Campbell - Gentoo Developer |
| 49 |
OpenPGP Key: 0x1EA055D6 @ hkp://keys.gnupg.net |
| 50 |
fpr: AE03 9064 AE00 053C 270C 1DE4 6F7A 9091 1EA0 55D6 |
Archives