Gentoo Archives: gentoo-dev

From: David Seifert <soap@g.o>
To: Ulrich Mueller <ulm@g.o>
Cc: gentoo-dev@l.g.o, python@g.o
Subject: Re: [gentoo-dev] [PATCH 1/3] python-any-r1.eclass: Constrain to EAPI >= 5
Date: Sat, 14 Dec 2019 11:52:21
Message-Id: ac81ae12582561863fe26a457bd4bee9772583db.camel@gentoo.org
In Reply to: Re: [gentoo-dev] [PATCH 1/3] python-any-r1.eclass: Constrain to EAPI >= 5 by Ulrich Mueller
1 On Sat, 2019-12-14 at 12:29 +0100, Ulrich Mueller wrote:
2 > > > > > > On Sat, 14 Dec 2019, David Seifert wrote:
3 > > case "${EAPI:-0}" in
4 > > - 0|1|2|3|4|5|6|7)
5 > > + [01234])
6 > > + die "Unsupported EAPI=${EAPI:-0} (too old) for
7 > > ${ECLASS}"
8 > > + ;;
9 > > + [567])
10 > > ;;
11 > > *)
12 > > die "Unsupported EAPI=${EAPI} (unknown) for ${ECLASS}"
13 >
14 > I know that this exists in other eclasses as well, but do we really
15 > need
16 > that distinction in the error message for "too old" and "unknown"
17 > EAPIs?
18 > It should be pretty clear which case applies there, especially since
19 > the
20 > message is addressed at developers, not users.
21 >
22 > Ulrich
23
24 This was just copypasta from the other python-r1.eclass. I personally
25 don't care either way, it should IMO just be consistent across the
26 tree.