| 1 |
On 15.04.2012 17:12, Pacho Ramos wrote: |
| 2 |
> El dom, 15-04-2012 a las 16:02 +0200, Michał Górny escribió: |
| 3 |
>> On Sun, 15 Apr 2012 11:59:50 +0200 |
| 4 |
>> Pacho Ramos <pacho@g.o> wrote: |
| 5 |
>> |
| 6 |
>>> I am unsure about validate_desktop_entries() utility. It's currently |
| 7 |
>>> provided by eutils.eclass and only called by net-firewall/fwbuilder. |
| 8 |
>>> Shouldn't this be moved to a "qa" check? Current way is pretty useless |
| 9 |
>>> as it's not used by most of packages, and calling it from a lot of |
| 10 |
>>> eclasses/ebuilds doesn't sound me like a good idea. |
| 11 |
>>> |
| 12 |
>>> What do you think? |
| 13 |
>> |
| 14 |
>> Agreed. It should be in repoman. |
| 15 |
>> |
| 16 |
> |
| 17 |
> The check needs to be run over desktop file going to be installed, not |
| 18 |
> sure how repoman can handle it, it looked to me more like a emerge job |
| 19 |
> (like is done with other qa checks run before installation) |
| 20 |
|
| 21 |
There's actually already code in repoman that runs |
| 22 |
desktop-file-validate. It of course only works for installed packages. |
| 23 |
Someone could make it run runtime too. |
| 24 |
|
| 25 |
Regards, |
| 26 |
Petteri |
Archives