Re: [gentoo-dev] New package neomutt

[Floyd Anderson]

Hi Nicolas,

below just some remarks from me.

On Mo, 31 Jul 09:23:51 +0200
Nicolas Bock <nicolasbock@g.o> wrote:
>On Mon, Jul 31, 2017 at 09:11:19AM +0200, Nicolas Bock wrote:
>>Hi,
>>
>>I would like to add neomutt to the tree. This new package is meant
>>as an alternative and not a replacement of the existing mutt
>>package.

+1 Very nice idea, I appreciate that.

>From 63f5d569aec514d67645b1c2e891e51810bb7ab5 Mon Sep 17 00:00:00 2001
>From: Nicolas Bock <nicolasbock@g.o>
>Date: Mon, 31 Jul 2017 09:06:07 +0200
>Subject: [PATCH] mail-client/neomutt: New package mail-client/neomutt-20170714
>
>Package-Manager: Portage-2.3.6, Repoman-2.3.1
>---
>mail-client/neomutt/Manifest                |   1 +
>mail-client/neomutt/metadata.xml            |  24 +++++
>mail-client/neomutt/neomutt-20170714.ebuild | 161 ++++++++++++++++++++++++++++
>3 files changed, 186 insertions(+)
>create mode 100644 mail-client/neomutt/Manifest
>create mode 100644 mail-client/neomutt/metadata.xml
>create mode 100644 mail-client/neomutt/neomutt-20170714.ebuild
>
>diff --git a/mail-client/neomutt/Manifest b/mail-client/neomutt/Manifest

[…]

>diff --git a/mail-client/neomutt/metadata.xml b/mail-client/neomutt/metadata.xml

[…]

>diff --git a/mail-client/neomutt/neomutt-20170714.ebuild b/mail-client/neomutt/neomutt-20170714.ebuild
>new file mode 100644
>index 00000000000..9bcf72e7479
>--- /dev/null
>+++ b/mail-client/neomutt/neomutt-20170714.ebuild
>@@ -0,0 +1,161 @@
>+# Copyright 1999-2017 Gentoo Foundation
>+# Distributed under the terms of the GNU General Public License v2
>+# $Id$

Drop $Id$ per council decision in bug #611234.

[1] <https://bugs.gentoo.org/show_bug.cgi?id=611234>

>+
>+EAPI=6
>+
>+inherit autotools eutils flag-o-matic
>+
>+DESCRIPTION="A small but very powerful text-based mail client"

Why not assimilate upstream (NeoMutt) motto? Mutt upstream has no objects on
this, see [2].

[2] <https://github.com/neomutt/neomutt/issues?utf8=%E2%9C%93&q=motto>

>+HOMEPAGE="https://www.neomutt.org/"
>+SRC_URI="https://github.com/${PN}/${PN}/archive/${P}.tar.gz"
>+
>+LICENSE="GPL-2"
>+SLOT="0"
>+KEYWORDS="~amd64 ~x86"
>+IUSE="berkdb crypt debug doc gdbm gnutls gpg idn kerberos libressl mbox nls
>+	notmuch qdbm sasl selinux slang smime ssl tokyocabinet vanilla"
>+

[…]

>+
>+src_install() {
>+	emake DESTDIR="${D}" install || die "install failed"
>+	if use mbox; then
>+		insinto /etc/neomutt
>+		newins "${FILESDIR}"/Muttrc.mbox Muttrc
>+	else
>+		insinto /etc/neomutt
>+		doins "${FILESDIR}"/Muttrc
>+	fi
>+
>+	# A newer file is provided by app-misc/mime-types. So we link it.
>+	rm "${ED}"/etc/${PN}/mime.types
>+	dosym /etc/mime.types /etc/${PN}/mime.types
>+
>+	# A man-page is always handy, so fake one
>+	if use !doc; then
>+		emake -C doc DESTDIR="${D}" muttrc.man || die
>+		# make the fake slightly better, bug #413405
>+		sed -e 's#@docdir@/manual.txt#http://www.mutt.org/doc/devel/manual.html#' \
>+			-e 's#in @docdir@,#at http://www.mutt.org/,#' \
>+			-e "s#@sysconfdir@#${EPREFIX}/etc/${PN}#" \
>+			-e "s#@bindir@#${EPREFIX}/usr/bin#" \
>+			doc/mutt.man > mutt.1
>+		cp doc/muttrc.man muttrc.5
>+		doman mutt.1 muttrc.5
>+	else
>+		# nuke manpages that should be provided by an MTA, bug #177605
>+		rm "${ED}"/usr/share/man/man5/{mbox,mmdf}.5 \
>+			|| ewarn "failed to remove files, please file a bug"
>+	fi
The *devel* manual is located here [3] and release manual here [4].

[3] <https://dev.mutt.org/doc/manual.html>
[4] <http://www.mutt.org/doc/manual/>

>+
>+	dodoc COPYRIGHT ChangeLog.md OPS* README*
>+}
>--
>2.13.0
>
>
>--
>Nicolas Bock <nicolasbock@g.o>

In the end it would be nice if Lua would also be integrated.

In the case you haven’t noticed that, have a look at [5]. But note the link [6]
for the faked manual page is dead if you consider to use this one. Also it
seems the documentation will be restructured in the future [7][8].

[5] <https://github.com/neomutt/gentoo-neomutt/tree/master/mail-client/neomutt>
[6] <http://www.neomutt.org/doc/devel/manual.html>
[7] <http://mailman.neomutt.org/pipermail/neomutt-devel-neomutt.org/2017-June/000438.html>
[8] <http://mailman.neomutt.org/pipermail/neomutt-devel-neomutt.org/2017-June/000467.html>

-- 
Regards,
floyd