Gentoo Archives: gentoo-dev

From: "Tomáš Chvátal" <scarabeus@g.o>
To: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] Re: perl-module.class review
Date: Mon, 21 Sep 2009 15:40:32
Message-Id: 200909211739.01116.scarabeus@gentoo.org
In Reply to: [gentoo-dev] Re: perl-module.class review by Torsten Veller
1 Dne pondělí 21 Září 2009 17:29:26 Torsten Veller napsal(a):
2 > * Ciaran McCreesh <ciaran.mccreesh@××××××××××.com>:
3 > > Torsten Veller <tove@g.o> wrote:
4 > > > +EXPORTED_FUNCTIONS="src_unpack src_compile src_test src_install"
5 > >
6 > > You're probably not the only one using this trick, so it might be wise
7 > > to use PERL_EXPORTED_FUNCTIONS or somesuch to avoid name collisions
8 > > with other eclasses.
9 >
10 > git and x-modular use EXPORTED_FUNCTIONS and
11 > cmake and xfconf use EXPF.
12 >
13 > | eclass/git.eclass:EXPORT_FUNCTIONS ${EXPORTED_FUNCTIONS}
14 > | eclass/x-modular.eclass:EXPORT_FUNCTIONS ${EXPORTED_FUNCTIONS}
15 > |
16 > | eclass/cmake-utils.eclass:EXPORT_FUNCTIONS ${EXPF}
17 > | eclass/xfconf.eclass:EXPORT_FUNCTIONS ${EXPF}
18 >
19 > I'll use PERL_EXPORTED_FUNCTIONS in the perl eclass.
20 >
21 > Thanks :)
22 >
23 I think it is not required
24 EXPF="src_compile src_test src_install" <- definition, also nulls anything
25 what was in it before :]
26 case ${EAPI:-0} in
27 2) EXPF="${EXPF} src_configure" ;;
28 1|0) ;;
29 *) die "Unknown EAPI, Bug eclass maintainers." ;;
30 esac
31 EXPORT_FUNCTIONS ${EXPF} <- export
32
33 i used expf cause it was shorter
34 and in git eclass i was too lazy for adjusting for the shorter name :]

Attachments

File name MIME type
signature.asc application/pgp-signature

Replies

Subject Author
[gentoo-dev] Re: perl-module.class review Torsten Veller <tove@g.o>
Re: [gentoo-dev] Re: perl-module.class review Maciej Mrozowski <reavertm@××××××.fm>