Gentoo Archives: gentoo-dev

From: Peter Johanson <latexer@g.o>
To: Eric Noack <eric.noack@×××.de>
Cc: gentoo-dev@g.o, chadh@g.o
Subject: Re: [gentoo-dev] which contribution prefered - to gentoo or to project itself?
Date: Sun, 11 May 2003 19:02:17
In Reply to: [gentoo-dev] which contribution prefered - to gentoo or to project itself? by Eric Noack
On Sun, May 11, 2003 at 08:36:23PM +0200, Eric Noack wrote:
> however unfortunately i needed support for an isdn pcmcia card, and > pcmcia-cs has no isdn support or drivers at all.
> > on the other side, adding the support to pcmcia_cs is as easy as copying a single driver file > (something_cs.c) from linux/drivers/isdn/hisax/ into the pcmcia-cs source tree > and add it to the make file, if only the kernel hisax driver has been compiled with support > for the pcmcia chip > > (which is possible without enabling kernel pcmcia, only the carddriver itself > cant be compiled without) > > so it would be easy to write a patch to pcmcia_cs that would check whether the kernel has > isdn and hisax support, and which pcmcia-chip-protocols have been compiled into the hisax driver, > and copy & compile the needed *_cs.c from the hisax dir
The check would definitely be good, but i'm hesitant to blindly copy files over from /usr/src/linux (which may contain any bastardization of the linux kernel with unknown patches, etc) and attempting to compile it. i think it'd be better to push a packaged tarball to gentoo mirrors that hold the necessary driver pieces. That way, we can test that things actually work. If we copy over from /usr/src/linux, we have no way of verifying things will work.
> > however this "patch" could be completely provided by a modified ebuild, maybe with support for an > "isdn" USEflag or such, too, eventually more easily than modifying the pcmcia_cs configure script
i definitely don't think this warrants a new USE flag, unless there's quite a few more ebuilds that would benefit from it. As long as we can verify that no compilation errors will occur, i see no problems with doing this by default (given the above tests pass of course).
> > so before writing this modification as either a patch to pcmcia_cs or the ebuild or both (ebuild that adds the patch)
If we have a seperate tarball, We can do the testing in the ebuild and apply a patch to the pcmcia directory including the configure edit and the new *_cs.c files. also, i haven't scoured the pcmcia-cs m/l for this particular topic, but does david hinds intend to add this support eventually? chad, what do you think about this approach? any other ideas or implementations you see as being superior? -pete -- Peter Johanson <latexer@g.o> -- gentoo-dev@g.o mailing list