Gentoo Archives: gentoo-dev

From: "Michał Górny" <mgorny@g.o>
To: gentoo-dev@l.g.o
Cc: "Michał Górny" <mgorny@g.o>
Subject: [gentoo-dev] [PATCH 12/15] scons-utils.eclass: _scons_clean_makeopts, stop exporting cache vars
Date: Fri, 01 Jan 2016 16:50:05
Message-Id: 1451666481-22145-13-git-send-email-mgorny@gentoo.org
In Reply to: [gentoo-dev] [PATCH 00/15] scons-utils.eclass: EAPI 6, better docs and cleanup by "Michał Górny"
1 Cache vars need only to be global to be preserved across calls.
2 Exporting them is undesired.
3 ---
4 eclass/scons-utils.eclass | 4 ++--
5 1 file changed, 2 insertions(+), 2 deletions(-)
6
7 diff --git a/eclass/scons-utils.eclass b/eclass/scons-utils.eclass
8 index 4da2c4a..82e45e3 100644
9 --- a/eclass/scons-utils.eclass
10 +++ b/eclass/scons-utils.eclass
11 @@ -177,7 +177,7 @@ _scons_clean_makeopts() {
12 debug-print "Cache hit: [${SCONSOPTS}]"
13 return
14 fi
15 - export _SCONS_CACHE_MAKEOPTS=${*}
16 + _SCONS_CACHE_MAKEOPTS=${*}
17
18 while [[ ${#} -gt 0 ]]; do
19 case ${1} in
20 @@ -236,7 +236,7 @@ _scons_clean_makeopts() {
21 done
22
23 set -- ${new_makeopts}
24 - export _SCONS_CACHE_SCONSOPTS=${*}
25 + _SCONS_CACHE_SCONSOPTS=${*}
26 debug-print "New SCONSOPTS: [${*}]"
27 SCONSOPTS=${*}
28 }
29 --
30 2.6.4