1 |
On Sun, Sep 8, 2019 at 11:24 PM Michał Górny <mgorny@g.o> wrote: |
2 |
|
3 |
> Hi, |
4 |
> |
5 |
> This is something I'd like to pass to the Council for the next meeting. |
6 |
> |
7 |
> TL;DR: I'd like to allow using pkgcheck instead of repoman because it's |
8 |
> 5-26 times faster and more convenient to use. |
9 |
> |
10 |
> |
11 |
> The current policy requires you to test your packages with repoman prior |
12 |
> to committing. However, repoman is both pretty inconvenient, unreadable |
13 |
> and slow. For example, for the cleanup of old versions in 4 packages I |
14 |
> have staged right now: |
15 |
> |
16 |
> $ time sh -c '(for x in $(git diff --name-only origin | cut -d/ -f1-2 | |
17 |
> uniq); do ( cd $x && repoman full -d ); done)' |
18 |
> |
19 |
> RepoMan scours the neighborhood... |
20 |
> RepoMan sez: "If everyone were like you, I'd be out of business!" |
21 |
> |
22 |
> RepoMan scours the neighborhood... |
23 |
> RepoMan sez: "If everyone were like you, I'd be out of business!" |
24 |
> |
25 |
> RepoMan scours the neighborhood... |
26 |
> repo.eapi-deprecated 1 |
27 |
> media-libs/stops/stops-0.3.0-r1.ebuild: 5 |
28 |
> RepoMan sez: "You're only giving me a partial QA payment? |
29 |
> I'll take it this time, but I'm not happy." |
30 |
> |
31 |
> RepoMan scours the neighborhood... |
32 |
> RepoMan sez: "If everyone were like you, I'd be out of business!" |
33 |
> |
34 |
> real 1m46,236s |
35 |
> user 1m38,524s |
36 |
> sys 0m7,818s |
37 |
> |
38 |
> |
39 |
> For comparison, pkgcheck: |
40 |
> |
41 |
> $ time pkgcheck scan --git-disable $(git diff origin --name-only | cut -d/ |
42 |
> -f1-2 | sort -u) |
43 |
> media-libs/stops |
44 |
> DeprecatedEAPI: version 0.3.0-r1: uses deprecated EAPI 5 |
45 |
> |
46 |
> real 0m4,408s |
47 |
> user 0m3,985s |
48 |
> sys 0m0,559s |
49 |
> |
50 |
> |
51 |
> Note that this is with warm profile cache. Without it: |
52 |
> |
53 |
> $ time pkgcheck scan --profile-cache false --git-disable $(git diff origin |
54 |
> --name-only | cut -d/ -f1-2 | sort -u) |
55 |
> media-libs/stops |
56 |
> DeprecatedEAPI: version 0.3.0-r1: uses deprecated EAPI 5 |
57 |
> |
58 |
> real 0m18,791s |
59 |
> user 0m16,279s |
60 |
> sys 0m0,611s |
61 |
> |
62 |
> |
63 |
> PkgCheck implements most of the checks currently in repoman, |
64 |
> and implements some more (e.g. for bad SRC_URI filenames). It finally |
65 |
> had new releases recently, and I think it's matured enough for basic |
66 |
> development work. |
67 |
> |
68 |
|
69 |
Generally speaking if stuff passes CI I'm happy, and if it doesn't I'm |
70 |
unhappy. That being said, do we think there any critical repoman checks |
71 |
that pkgcore does not implement? |
72 |
|
73 |
Is there a plan for continued maintenance? E.g. when EAPI-next comes out I |
74 |
suspect repoman will get it (via portage), but pkgcore struggled to pick up |
75 |
new EAPIs as quickly. You mentioned pkgcheck had some releases; do we |
76 |
expect this to continue? |
77 |
|
78 |
-A |
79 |
|
80 |
|
81 |
> WDYT? |
82 |
> |
83 |
> -- |
84 |
> Best regards, |
85 |
> Michał Górny |
86 |
> |
87 |
> |