Gentoo Archives: gentoo-dev

From: Mike Frysinger <vapier@g.o>
To: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] RFC: fox.eclass update
Date: Fri, 17 Sep 2010 06:07:08
Message-Id: 201009170124.28352.vapier@gentoo.org
In Reply to: Re: [gentoo-dev] RFC: fox.eclass update by Peter Volkov
1 On Friday, September 17, 2010 01:06:19 Peter Volkov wrote:
2 > В Чтв, 16/09/2010 в 18:34 -0400, Mike Frysinger пишет:
3 > > On Thursday, September 16, 2010 15:41:27 Peter Volkov wrote:
4 > > > В Чтв, 16/09/2010 в 15:29 -0400, Mike Frysinger пишет:
5 > > > > > FOX_PV="${FOX_PV:-${PV}}"
6 > > > >
7 > > > > while you're here, i'd change to:
8 > > > > : ${FOX_PV:=${PV}}
9 > > >
10 > > > Why? This looks less readable...
11 > >
12 > > only because your eyes arent tuned to it
13 >
14 > Instead of explicit variable assignment (what was intended) you suggest
15 > to call `:` command and implicitly assign variable with bash parameter
16 > expansion...
17
18 what exactly is your point ? there is no performance difference. my style
19 suggestion however is significantly more compact and has no redundancy.
20 -mike

Attachments

File name MIME type
signature.asc application/pgp-signature