Gentoo Archives: gentoo-dev

From: Donnie Berkholz <dberkholz@g.o>
To: gentoo-dev@l.g.o, george@g.o
Subject: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in eclass: gnat.eclass
Date: Thu, 27 Sep 2007 01:09:21
Message-Id: 20070927005632.GW22279@supernova
1 On 20:41 Wed 26 Sep , George Shapovalov (george) wrote:
2 > george 07/09/26 20:41:34
3 >
4 > Modified: gnat.eclass
5 > Log:
6 > added get_active_profile helper function
7
8 > Revision Changes Path
9 > 1.28 eclass/gnat.eclass
10 >
11 > file : http://sources.gentoo.org/viewcvs.py/gentoo-x86/eclass/gnat.eclass?rev=1.28&view=markup
12 > plain: http://sources.gentoo.org/viewcvs.py/gentoo-x86/eclass/gnat.eclass?rev=1.28&content-type=text/plain
13 > diff : http://sources.gentoo.org/viewcvs.py/gentoo-x86/eclass/gnat.eclass?r1=1.27&r2=1.28
14
15 > +# Returns a name of active gnat profile. Peroroms some validity checks. No input
16 > +# parameters, analyzes the system setup directly.
17 > +get_active_profile() {
18 > + # get common code and settings
19 > + . ${GnatCommon} || die "failed to source gnat-common lib"
20 > +
21 > + local profiles=( $(get_env_list) )
22 > +
23 > + if [[ ${profiles[@]} == "${MARKER}*" ]]; then
24 > + exit
25
26 I'm surprised to see exit called in a function instead of returning
27 nonzero.
28
29 Thanks,
30 Donnie
31 --
32 gentoo-dev@g.o mailing list

Replies