Gentoo Archives: gentoo-dev

From: Samuli Suominen <ssuominen@g.o>
To: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] rfc: [patch]  bash-completion-r1.eclass: add support for pkg-config for migration to the new upstream defined bash-completion directories (prereq for bug 472938)
Date: Thu, 13 Jun 2013 09:08:04
Message-Id: 51B98B44.7090502@gentoo.org
In Reply to: Re: [gentoo-dev] rfc: [patch]  bash-completion-r1.eclass: add support for pkg-config for migration to the new upstream defined bash-completion directories (prereq for bug 472938) by Ulrich Mueller
1 On 13/06/13 09:59, Ulrich Mueller wrote:
2 >>>>>> On Thu, 13 Jun 2013, Samuli Suominen wrote:
3 >
4 >> On 13/06/13 07:58, Micha³ Górny wrote:
5 >>> Dnia 2013-06-13, o godz. 01:22:11 Samuli Suominen
6 >>> <ssuominen@g.o> napisa³(a):
7 >>>
8 >>>> what $subject says,
9 >>>>
10 >>>> "add support for pkg-config for migration to the new upstream
11 >>>> defined bash-completion directories (prereq for bug 472938)"
12 >>>>
13 >>>> http://bugs.gentoo.org/472938
14 >>>>
15 >>>> ie. the pkg-config file shipped *now* in portage is a hack from me
16 >>>> to postpone this
17 >>>>
18 >>>> pretty tired so more eyes is cool ;)
19 >>>
20 >>> You mean http://thread.gmane.org/gmane.linux.gentoo.devel/85258 ?
21 >>>
22 >>> I think you've got to convince ulm in the first place.
23 >
24 >> His concerns was actually already covered by the first post and the
25 >> linked bug:
26 >
27 >> This is required for smooth migration path from old to new
28 >> directories. Back when the old thread happened, there was only one
29 >> possible value for completions dir, now there is two. And nothing
30 >> prevents upstream adding/changing the values in the .pc file yet
31 >> again for next release, this should be dynamic -- just like
32 >> $(get_udevdir), $(get_libdir) etc.
33 >
34 > Nothing is covered. If you change the installation dir for the
35 > completion modules, then eselect bashcomp won't be able to find them
36 > any more. So you need a transition plan.
37
38 Sorry if I wasn't clear:
39
40 http://bugs.gentoo.org/show_bug.cgi?id=472938#c1
41
42 "I think we should eventually get rid of the eselect module and load
43 everything dynamically."
44
45 So what is left, after committing those posted diff's:
46
47 - Removal of bash-completion specific snippets from app-admin/eselect as
48 it's no-op with the new way. This is more of a matter of cleanup after
49 rest of the work is done. Although, if you want something more complex,
50 then by all means...
51
52 - Postinstallation instructions to the new bash-completion to run qfile
53 combination with emerge to re-emerge packages to move files to correct
54 directory. Trivial to accomplish. Dunno why I didn't already put it to
55 the diff.
56
57 As in, there is a complete transition plan in place far as I can see. I
58 succesfully migrated already locally.

Replies