Re: [gentoo-dev] [PATCH] eutils.eclass: Show death notice only when user patches were really applied

[Ulrich Mueller]

>>>>> On Mon, 22 Aug 2016, Thomas Deutschmann wrote:

> [...]

> This commit adds a new global variable "EPATCH_N_APPLIED_PATCHES"
> which tracks the number of applied user patches. This allows us to
> only show the notice when user patches were really applied.

I wonder if extending an obsolete feature is worth the effort.
In EAPI 6, epatch_user has been replaced by eapply_user.
 
> +		: $(( EPATCH_N_APPLIED_PATCHES++ ))

Why not simply:
		(( EPATCH_N_APPLIED_PATCHES++ ))

> +			if [[ ${old_n_applied_patches} -lt ${EPATCH_N_APPLIED_PATCHES} ]]; then
> +				has epatch_user_death_notice ${EBUILD_DEATH_HOOKS} || EBUILD_DEATH_HOOKS+=" epatch_user_death_notice"

Please keep lines no wider than 80 character positions.

Ulrich