Gentoo Archives: gentoo-dev

From: Tomas Mozes <hydrapolic@×××××.com>
To: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] Fixing elasticsearch maintainer
Date: Sat, 20 May 2017 19:58:02
Message-Id: CAG6MAzQq-8c2+ngz5u2CJTv-7Q=YE9jfH6038PKmYE3SoRNfWw@mail.gmail.com
In Reply to: Re: [gentoo-dev] Fixing elasticsearch maintainer by Patrick Lauer
1 On Fri, May 19, 2017 at 6:50 PM, Patrick Lauer <patrick@g.o> wrote:
2
3 > I tried removing proxy-maint from metadata after multiple discussions
4 > failed. Extra happiness towards monsieurp "but the GH PR is over 3 days
5 > old, I have to commit" and gokturk "Yes I understand. I commit anyway"
6 >
7 > This has been an uphill struggle since about October, around New Year I
8 > stopped actively caring, and since these two commits:
9 >
10 > 12c3eacda7c4d23686eaf10eab21d810cc95ea49
11 > f42d6679c038c3efcc257d38547267d01823aea9
12 >
13 > I see no way to fix this situation that doesn't involve a review board in
14 > front of all proxy-maint commits. Because we discussed this in IRC, and
15 > still ... "but is open bug"
16 >
17 > However, as far as I'm aware none of this happened. Note that I might
18 >> have missed the mail, or it might have been sent before I joined --
19 >> correct me if that is the case.
20 >>
21 >
22 > There were multiple discussions in IRC, which the involved people usually
23 > forgot within about 20 minutes and then resumed doing stuff.
24 >
25 > I tried removing proxy-maint from metadata, which was reverted (sooo how
26 > does one *not* have constant interference?)
27 >
28 > As Alec pointed out, it is a normal procedure in Gentoo to remove old
29 >> versions of software if there is no explicit indication that they need
30 >> to be kept. Therefore, I don't see anything wrong with the proxied
31 >> maintainer wishing to clean the old versions up and/or not requesting
32 >> your explicit permission for that. If you needed the old versions, you
33 >> should have made that clear.
34 >>
35 >
36 > One could ask, maybe. I guess I can (mis)understand this to mean that I
37 > can do with packages with you in metadata what I want because ... err...
38 > shiny!
39 >
40 > I should also point out that the steps you've taken (and listed in this
41 >> mail) are not really relevant. They make you look like a sloppy
42 >> maintainer, and a bad Gentoo developer at the best -- and I doubt anyone
43 >> would connect removing proxy-maint team with a necessity of keeping
44 >> an old version.
45 >>
46 >
47 > The cooperation that I had with ferki was pretty good (mostly because we
48 > sat next to each other in the office). The contributions from Tomas were on
49 > average pretty ok, just needed some minor cleanups here and there.
50 >
51 > The blind "but PR is open for 3 days" commits from proxy-maint made it
52 > extremely hard to review what changed in a timely manner, so that I
53 > basically didn't want to care for this pile of stupid for the last, ahem, 6
54 > months or so. Especially since whenever I wanted to review things some
55 > joker made some new changes which made me go "eh whut how you? banana
56 > banana!" so I pushed reviewing a week into the future and ...
57 >
58 > I have no idea how I could have fixed this without the QA+Comrel banhammer
59 > combo, which is a totally insane "fix" to a problem that shouldn't even
60 > exist. But I see no other options how to make people understand that "No
61 > means no".
62 >
63 > Is this the new normal?
64 >
65 >
66
67 Everybody makes mistakes, but let's look from another perspective.
68 Elasticsearch 5.0 got released - a new major version. You did the bump, but
69 it didn't work (it was clearly pushed to the repo untested as
70 openrc/systemd version both failed:
71 https://bugs.gentoo.org/show_bug.cgi?id=598732
72 https://bugs.gentoo.org/show_bug.cgi?id=597454
73 Why didn't you fix it yourself?
74
75 Same for logstash:
76 https://bugs.gentoo.org/show_bug.cgi?id=597452
77 https://bugs.gentoo.org/show_bug.cgi?id=598422
78 Why did you commit a broken ebuild to the repo and never fixed it after
79 yourself? These bugs were open for weeks and months, not days...

Replies

Subject Author
Re: [gentoo-dev] Fixing elasticsearch maintainer "Michał Górny" <mgorny@g.o>