Gentoo Archives: gentoo-dev

From: Michael Haubenwallner <haubi@g.o>
To: gentoo-dev@l.g.o, Michael Palimaka <kensington@g.o>, heroxbd@g.o
Cc: kde@g.o
Subject: [gentoo-dev] Re: [PATCH] eclass/cmake-utils.eclass: restrict rpath hack to Prefix/rpath
Date: Wed, 31 Jul 2019 07:48:34
Message-Id: cc6516b9-d3f1-0965-a494-42c6373a81a4@gentoo.org
In Reply to: [gentoo-dev] Re: [PATCH] eclass/cmake-utils.eclass: restrict rpath hack to Prefix/rpath by Michael Palimaka
1 On 7/15/19 2:45 PM, Michael Palimaka wrote:
2 > On 7/12/19 3:14 AM, heroxbd@g.o wrote:
3 >> From: Benda Xu <heroxbd@g.o>
4 >>
5 >>    Prefix/standalone does not need it.
6 >> ---
7 >>   eclass/cmake-utils.eclass | 2 +-
8 >>   1 file changed, 1 insertion(+), 1 deletion(-)
9 >>
10 >> diff --git a/eclass/cmake-utils.eclass b/eclass/cmake-utils.eclass
11 >> index ea1858e9735f..109b584afb39 100644
12 >> --- a/eclass/cmake-utils.eclass
13 >> +++ b/eclass/cmake-utils.eclass
14 >> @@ -612,7 +612,7 @@ cmake-utils_src_configure() {
15 >>           fi
16 >>       fi
17 >>   -    if [[ ${EPREFIX} ]]; then
18 >> +    if use prefix-guest; then
19 >>           cat >> "${build_rules}" <<- _EOF_ || die
20 >>               # in Prefix we need rpath and must ensure cmake gets our default linker path
21 >>               # right ... except for Darwin hosts
22 >>
23 >
24 > This seems to break non-prefix builds, as the prefix-guest USE flag will not exist.
25 >
26
27 Note that IUSE_IMPLICIT="prefix prefix-guest prefix-stack" is set in the base profile
28 of Gentoo mainline. So the flag really should "exist" in non-prefix builds as well.
29
30 /haubi/