Gentoo Archives: gentoo-dev

From: Mike Gilbert <floppym@g.o>
To: gentoo-dev@l.g.o
Cc: Mike Gilbert <floppym@g.o>
Subject: [gentoo-dev] [PATCH v2] python-utils-r1.eclass: avoid nested ebegin calls
Date: Mon, 11 Jul 2022 13:16:55
Message-Id: 20220711131609.3457267-1-floppym@gentoo.org
In Reply to: [gentoo-dev] [PATCH] python-utils-r1.eclass: avoid nested ebegin calls by Mike Gilbert
1 It's common for python_check_deps to call python_has_version, which
2 calls ebegin itself.
3
4 Signed-off-by: Mike Gilbert <floppym@g.o>
5 ---
6 eclass/python-utils-r1.eclass | 9 ++++++---
7 1 file changed, 6 insertions(+), 3 deletions(-)
8
9 diff --git a/eclass/python-utils-r1.eclass b/eclass/python-utils-r1.eclass
10 index a18ca58475f..5c678c524ae 100644
11 --- a/eclass/python-utils-r1.eclass
12 +++ b/eclass/python-utils-r1.eclass
13 @@ -1399,9 +1399,12 @@ _python_run_check_deps() {
14
15 local PYTHON_USEDEP="python_targets_${impl}(-)"
16 local PYTHON_SINGLE_USEDEP="python_single_target_${impl}(-)"
17 - ebegin " python_check_deps"
18 - python_check_deps
19 - eend ${?}
20 + einfo " python_check_deps"
21 + if python_check_deps; then
22 + einfo " python_check_deps succeeded"
23 + else
24 + einfo " python_check_deps failed"
25 + fi
26 }
27
28 # @FUNCTION: python_has_version
29 --
30 2.37.0

Replies