Gentoo Archives: gentoo-dev

From: Andreas Sturmlechner <asturm@g.o>
To: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] [PATCH 2/2] cmake-utils.eclass: Enable BUILD_SHARED_LIBS by default in EAPI >= 7
Date: Thu, 13 Sep 2018 09:56:05
Message-Id: 2549345.rO708uWdeg@tux200s
In Reply to: [gentoo-dev] [PATCH 2/2] cmake-utils.eclass: Enable BUILD_SHARED_LIBS by default in EAPI >= 7 by soap@gentoo.org
1 ---Original Message---
2 On Thursday, 26 July 2018 at 08:35, soap@g.o wrote:
3
4 > From: David Seifert <soap@g.o>
5 >
6 > * Many upstreams build static libraries by default, as this is
7 > simpler for distribution. Developers can still override this
8 > variable if required.
9 >
10 > Examples:
11 > https://github.com/pezmaster31/bamtools/blob/master/CMakeLists.txt#L64
12 > ---
13 > eclass/cmake-utils.eclass | 1 +
14 > 1 file changed, 1 insertion(+)
15 >
16 > diff --git a/eclass/cmake-utils.eclass b/eclass/cmake-utils.eclass
17 > index ed81426ddcc..f180c8c3d7d 100644
18 > --- a/eclass/cmake-utils.eclass
19 > +++ b/eclass/cmake-utils.eclass
20 > @@ -623,6 +623,7 @@ cmake-utils_src_configure() {
21 > if [[ ${EAPI} != [56] ]]; then
22 > cat >> "${common_config}" <<- _EOF_ || die
23 > SET (CMAKE_INSTALL_DOCDIR "${EPREFIX}/usr/share/doc/${PF}" CACHE PATH "")
24 > + SET (BUILD_SHARED_LIBS ON CACHE BOOLEAN "")
25 > _EOF_
26 > fi
27 >
28 > --
29 > 2.18.0
30
31 works for me.