Gentoo Archives: gentoo-dev

From: "Harald van Dijk" <truedfx@g.o>
To: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] Minor changes in python.eclass and distutils.eclass
Date: Mon, 05 Jul 2010 17:43:09
Message-Id: 20100705174338.GA29469@boostbox
In Reply to: Re: [gentoo-dev] Minor changes in python.eclass and distutils.eclass by "Harald van Dijk"
1 On Mon, Jul 05, 2010 at 07:38:32PM +0200, Harald van Dijk wrote:
2 > On Mon, Jul 05, 2010 at 07:01:27PM +0200, Arfrever Frehtes Taifersar Arahesis wrote:
3 > > 2010-07-05 18:36:09 Tomáš Chvátal napisał(a):
4 > > > Dne 5.7.2010 18:34, Arfrever Frehtes Taifersar Arahesis napsal(a):
5 > > > > python.eclass uses colors for build time outputting, which doesn't communicate anything for users.
6 > > > >
7 > > > + echo " ${_RED}*${_NORMAL} ${_RED}Deprecation Warning: NEED_PYTHON
8 > > > variable is deprecated and will be banned on 2010-10-01.${_NORMAL}"
9 > > > + echo " ${_RED}*${_NORMAL} ${_RED}Use PYTHON_DEPEND variable instead of
10 > > > NEED_PYTHON variable.${_NORMAL}"
11 > > > + echo " ${_RED}*${_NORMAL} ${_RED}The ebuild needs to be fixed. Please
12 > > > report a bug, if it has not been already reported.${_NORMAL}"
13 > > >
14 > > > The above is build outputting since when?
15 > >
16 > > The colored, non-logged output in deprecation warnings is used as exception to increase
17 > > the chance that ebuild maintainers will be notified earlier about the necessity of changes
18 > > in given ebuilds.
19 >
20 > einfo/ewarn/eerror output is repeated by default when emerge exits. By
21 > not using einfo/ewarn/eerror, you are making it less likely that others
22 > will be reading your deprecation notices.
23
24 Ugh. I see that you're using einfo already and suppressing its output.
25 In that case, my objection doesn't apply, but it's still nasty.