Gentoo Archives: gentoo-dev

From: James Le Cuirot <chewi@g.o>
To: gentoo-dev <gentoo-dev@l.g.o>
Cc: James Le Cuirot <chewi@g.o>
Subject: [gentoo-dev] [PATCH 09/12] python-any-r1.eclass: Export PYTHON after checking whether installed
Date: Thu, 03 Jan 2019 21:43:38
Message-Id: 20190103213924.22835-10-chewi@gentoo.org
In Reply to: [gentoo-dev] [PATCH] Eclass changes for cross-compiling Python modules by James Le Cuirot
1 This previously happened before checking but now exporting PYTHON
2 involves creating the wrappers, which requires the requested Python to
3 be installed.
4
5 We could also drop all the calls to python_wrapper_setup as this is
6 now already done when exporting PYTHON but it doesn't hurt to be
7 explicit.
8
9 Signed-off-by: James Le Cuirot <chewi@g.o>
10 ---
11 eclass/python-any-r1.eclass | 6 +++---
12 1 file changed, 3 insertions(+), 3 deletions(-)
13
14 diff --git a/eclass/python-any-r1.eclass b/eclass/python-any-r1.eclass
15 index 7a91507a600f..7c5ae87872eb 100644
16 --- a/eclass/python-any-r1.eclass
17 +++ b/eclass/python-any-r1.eclass
18 @@ -1,4 +1,4 @@
19 -# Copyright 1999-2018 Gentoo Foundation
20 +# Copyright 1999-2019 Gentoo Authors
21 # Distributed under the terms of the GNU General Public License v2
22
23 # @ECLASS: python-any-r1.eclass
24 @@ -327,8 +327,8 @@ python_setup() {
25 # fallback to best installed impl.
26 # (reverse iteration over _PYTHON_SUPPORTED_IMPLS)
27 for (( i = ${#_PYTHON_SUPPORTED_IMPLS[@]} - 1; i >= 0; i-- )); do
28 - python_export "${_PYTHON_SUPPORTED_IMPLS[i]}" EPYTHON PYTHON
29 - if _python_EPYTHON_supported "${EPYTHON}"; then
30 + if _python_EPYTHON_supported "${_PYTHON_SUPPORTED_IMPLS[i]}"; then
31 + python_export "${_PYTHON_SUPPORTED_IMPLS[i]}" EPYTHON PYTHON
32 python_wrapper_setup
33 return
34 fi
35 --
36 2.19.2