1 |
-----BEGIN PGP SIGNED MESSAGE----- |
2 |
Hash: SHA1 |
3 |
|
4 |
On Fri, 30 Oct 2015 18:20:08 +0100 |
5 |
Michał Górny <mgorny@g.o> wrote: |
6 |
|
7 |
> On Fri, 30 Oct 2015 12:03:59 +0000 (UTC) |
8 |
> "Justin Lecher" <jlec@g.o> wrote: |
9 |
> |
10 |
> > commit: df8e399c9bac2dc30d7cf69c2462a81729a3ae69 |
11 |
> > Author: Justin Lecher <jlec <AT> gentoo <DOT> org> |
12 |
> > AuthorDate: Fri Oct 30 10:18:05 2015 +0000 |
13 |
> > Commit: Justin Lecher <jlec <AT> gentoo <DOT> org> |
14 |
> > CommitDate: Fri Oct 30 12:03:49 2015 +0000 |
15 |
> > URL: |
16 |
> > https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=df8e399c |
17 |
> > |
18 |
> > eclass: Use consistent place for then in if clause |
19 |
> |
20 |
> Excuse me but who are you exactly to take a random eclass and commit |
21 |
> random style changes inside without even bothering to contact |
22 |
> the author? |
23 |
> |
24 |
|
25 |
Well, what's this? he selected a random eclass? Then he recklessly |
26 |
committed a random style change? To my observation, the lead recruiter |
27 |
specifically selected the distutils-r1 eclass, not some random one like |
28 |
base.eclass, and carefully edited a couple of lines to put "; then" at |
29 |
the end of a line as is done in most any ebuild. So how RANDOM is that? |
30 |
In fact it isn't, however you have no hesitation in taking him to task |
31 |
not only over its randomness which isn't, but that he had the gaul to do |
32 |
it at all. |
33 |
|
34 |
Was it not you who insisted that I assign a bug over the func |
35 |
distutils_install_for_testing and you insisted I assign it to the |
36 |
python team, not to you as I did. You lectured me to follow the rules |
37 |
stating that it belongs to the python herd / project / w/e which may |
38 |
be authored by its members any time in the future. It seems you want it |
39 |
both ways. |
40 |
|
41 |
jlec is not only a member of python team but he is high ranked. That |
42 |
exactly is who he is. |
43 |
> Not to mention this commit message is incorrect as it doesn't state |
44 |
> which eclass was modified. |
45 |
> |
46 |
|
47 |
This is in fact correct. |
48 |
> > |
49 |
> > Signed-off-by: Justin Lecher <jlec <AT> gentoo.org> |
50 |
> > |
51 |
> > eclass/distutils-r1.eclass | 3 +-- |
52 |
> > 1 file changed, 1 insertion(+), 2 deletions(-) |
53 |
> > |
54 |
> > diff --git a/eclass/distutils-r1.eclass b/eclass/distutils-r1.eclass |
55 |
> > index 185dd4f..dbd27a7 100644 |
56 |
> > --- a/eclass/distutils-r1.eclass |
57 |
> > +++ b/eclass/distutils-r1.eclass |
58 |
> > @@ -322,8 +322,7 @@ distutils-r1_python_prepare_all() { |
59 |
> > |
60 |
> > _distutils-r1_disable_ez_setup |
61 |
> > |
62 |
> > - if [[ ${DISTUTILS_IN_SOURCE_BUILD} && ! |
63 |
> > ${DISTUTILS_SINGLE_IMPL} ]] |
64 |
> > - then |
65 |
> > + if [[ ${DISTUTILS_IN_SOURCE_BUILD} && ! |
66 |
> > ${DISTUTILS_SINGLE_IMPL} ]]; then |
67 |
> |
68 |
> This was intentionally wrapped to stay within 72-column line width. |
69 |
> Not saying the eclass is perfect in keeping text width, especially |
70 |
> with others committing random changes to it, but that's no reason to |
71 |
> introduce further offenders. |
72 |
> |
73 |
|
74 |
there's that random again. Once and for all mgorny get off your high |
75 |
horse. |
76 |
|
77 |
> > # create source copies for each implementation |
78 |
> > python_copy_sources |
79 |
> > fi |
80 |
> > |
81 |
> |
82 |
> |
83 |
> |
84 |
|
85 |
|
86 |
|
87 |
- -- |
88 |
kind regards |
89 |
|
90 |
Ian Delaney |
91 |
-----BEGIN PGP SIGNATURE----- |
92 |
Version: GnuPG v2.1 |
93 |
|
94 |
iKYEARECAGYFAlY0u/1fFIAAAAAALgAoaXNzdWVyLWZwckBub3RhdGlvbnMub3Bl |
95 |
bnBncC5maWZ0aGhvcnNlbWFuLm5ldDdDQUM1OUY0ODkzMERBREU1NUQ1RjJBRkIy |
96 |
OEVDMjEzQjgwNzJCMEQACgkQso7CE7gHKw3xZQCgyQb6Tyuw73CiBHgxXm/bvPX7 |
97 |
L1EAn0UfLOZTERZpMJN1VQXIgb81AkE6 |
98 |
=yt+k |
99 |
-----END PGP SIGNATURE----- |
100 |
|
101 |
|
102 |
-- |
103 |
kind regards |
104 |
|
105 |
Ian Delaney |