Gentoo Archives: gentoo-dev

From: "Michał Górny" <mgorny@g.o>
To: gentoo-dev@l.g.o
Cc: x11@g.o, "Michał Górny" <mgorny@g.o>
Subject: [gentoo-dev] [PATCH virtualx.eclass 2/5] Use eqawarn from eutils.eclass.
Date: Mon, 11 Feb 2013 22:16:47
Message-Id: 1360620883-22562-3-git-send-email-mgorny@gentoo.org
In Reply to: [gentoo-dev] [RFC/PATCH] A cleaner API for virtualx.eclass by "Michał Górny"
1 Instead of ewarn "QA: ...
2 ---
3 gx86/eclass/virtualx.eclass | 24 +++++++++++++-----------
4 1 file changed, 13 insertions(+), 11 deletions(-)
5
6 diff --git a/gx86/eclass/virtualx.eclass b/gx86/eclass/virtualx.eclass
7 index 47116fd..0da3066 100644
8 --- a/gx86/eclass/virtualx.eclass
9 +++ b/gx86/eclass/virtualx.eclass
10 @@ -9,6 +9,8 @@
11 # Original author: Martin Schlemmer <azarah@g.o>
12 # @BLURB: This eclass can be used for packages that needs a working X environment to build.
13
14 +inherit eutils
15 +
16 # @ECLASS-VARIABLE: VIRTUALX_REQUIRED
17 # @DESCRIPTION:
18 # Variable specifying the dependency on xorg-server and xhost.
19 @@ -46,15 +48,15 @@ case ${VIRTUALX_REQUIRED} in
20 ;;
21 optional|tests)
22 # deprecated section YAY.
23 - ewarn "QA: VIRTUALX_REQUIRED=optional and VIRTUALX_REQUIRED=tests are deprecated."
24 - ewarn "QA: You can drop the variable definition completely from ebuild,"
25 - ewarn "QA: because it is default behaviour."
26 + eqawarn "VIRTUALX_REQUIRED=optional and VIRTUALX_REQUIRED=tests are deprecated."
27 + eqawarn "You can drop the variable definition completely from ebuild,"
28 + eqawarn "because it is default behaviour."
29
30 if [[ -n ${VIRTUALX_USE} ]]; then
31 # so they like to specify the useflag
32 - ewarn "QA: VIRTUALX_USE variable is deprecated."
33 - ewarn "QA: Please read eclass manpage to find out how to use VIRTUALX_REQUIRED"
34 - ewarn "QA: to achieve the same behaviour."
35 + eqawarn "VIRTUALX_USE variable is deprecated."
36 + eqawarn "Please read eclass manpage to find out how to use VIRTUALX_REQUIRED"
37 + eqawarn "to achieve the same behaviour."
38 fi
39
40 [[ -z ${VIRTUALX_USE} ]] && VIRTUALX_USE="test"
41 @@ -170,9 +172,9 @@ virtualmake() {
42
43 # backcompat for maketype
44 if [[ -n ${maketype} ]]; then
45 - ewarn "QA: ebuild is exporting \$maketype=${maketype}"
46 - ewarn "QA: Ebuild should be migrated to use VIRTUALX_COMMAND=${maketype} instead."
47 - ewarn "QA: Setting VIRTUALX_COMMAND to \$maketype conveniently for now."
48 + eqawarn "ebuild is exporting \$maketype=${maketype}"
49 + eqawarn "Ebuild should be migrated to use VIRTUALX_COMMAND=${maketype} instead."
50 + eqawarn "Setting VIRTUALX_COMMAND to \$maketype conveniently for now."
51 VIRTUALX_COMMAND=${maketype}
52 fi
53
54 @@ -186,8 +188,8 @@ virtualmake() {
55 Xmake() {
56 debug-print-function ${FUNCNAME} "$@"
57
58 - ewarn "QA: you should not execute make directly"
59 - ewarn "QA: rather execute Xemake -j1 if you have issues with parallel make"
60 + eqawarn "you should not execute make directly"
61 + eqawarn "rather execute Xemake -j1 if you have issues with parallel make"
62 VIRTUALX_COMMAND="emake -j1" virtualmake "$@"
63 }
64
65 --
66 1.8.1.2