| 1 |
-----BEGIN PGP SIGNED MESSAGE----- |
| 2 |
Hash: SHA1 |
| 3 |
|
| 4 |
Joshua Nichols wrote: |
| 5 |
> Patrick McLean wrote: |
| 6 |
>> There is a new version at |
| 7 |
>> http://dev.gentoo.org/~chutzpah/profile.bashrc that |
| 8 |
>> should fix all these possible problems. Thanks for pointing them out, |
| 9 |
> Around line 77, you have: |
| 10 |
> hasme ${flag} ${CFLAGS} ${CXXFLAGS} && trigger=1 && \ |
| 11 |
> ewarn "Your C(XX)FLAGS contain(s) \"${flag}\" which can break |
| 12 |
> packages." |
| 13 |
> |
| 14 |
> Might I suggest you change it to something like: |
| 15 |
> |
| 16 |
> if hasme ${flag} ${CFLAGS} ${CXXFLAGS}; then |
| 17 |
> trigger=1 |
| 18 |
> ewarn "Your C(XX)FLAGS contain(s) \"${flag}\" which can break |
| 19 |
> packages." |
| 20 |
> fi |
| 21 |
> |
| 22 |
Done. |
| 23 |
|
| 24 |
> While there's nothing wrong with the original way, my suggestion would |
| 25 |
> make it a bit more obvious that you're setting the 'trigger' flag. |
| 26 |
> |
| 27 |
Readability is always a good thing :) |
| 28 |
-----BEGIN PGP SIGNATURE----- |
| 29 |
Version: GnuPG v1.4.2.2 (GNU/Linux) |
| 30 |
|
| 31 |
iD8DBQFEP+cJWt/XSf2CZdkRAoGtAJ9e8CViKyluILpEH07J3i50ciuNnwCZAVu/ |
| 32 |
M94FKLlae7tyTRZ8TsE40zA= |
| 33 |
=XkHW |
| 34 |
-----END PGP SIGNATURE----- |
| 35 |
-- |
| 36 |
gentoo-dev@g.o mailing list |
Archives