Gentoo Archives: gentoo-dev

From: Ulrich Mueller <ulm@g.o>
To: gentoo-dev@l.g.o
Cc: "Michał Górny" <mgorny@g.o>
Subject: Re: [gentoo-dev] [PATCH 1/8] bash-completion-r1.eclass: Sanitize insopts
Date: Fri, 08 Jun 2018 11:02:52
Message-Id: 23322.25166.268806.14233@a1i15.kph.uni-mainz.de
In Reply to: [gentoo-dev] [PATCH 1/8] bash-completion-r1.eclass: Sanitize insopts by "Michał Górny"
1 >>>>> On Fri, 8 Jun 2018, Michał Górny wrote:
2
3 > (
4 > + insopts
5 > insinto "$(_bash-completion-r1_get_bashcompdir)"
6 > doins "${@}"
7 > )
8
9 I wonder about these empty insopts commands. According to the spec:
10 "When called with no arguments, resets the option list [for the
11 install command] to empty."
12
13 Now the default permission mode of install(1) is rwxr-xr-x or 0755,
14 which is not what you want. So I think you should do an explicit
15 insopts -m 0644 here.
16
17 Similarly, exeopts -m 0755 in other commits (because IMHO it would
18 improve readability).
19
20 Ulrich

Replies