Gentoo Archives: gentoo-dev

From: Matt Turner <mattst88@g.o>
To: gentoo development <gentoo-dev@l.g.o>
Subject: Re: [gentoo-dev] Value of Continuous integration vs Code Review / Pull Requests
Date: Wed, 27 May 2020 21:31:14
Message-Id: CAEdQ38Ffhqo6+bStSyQPHhSuOpAE=DBZRVi1pkyswNGmZz7s3w@mail.gmail.com
In Reply to: Re: [gentoo-dev] Value of Continuous integration vs Code Review / Pull Requests by Alec Warner
1 On Wed, May 27, 2020 at 1:14 AM Alec Warner <antarus@g.o> wrote:
2 > On Tue, May 26, 2020, 23:08 Michał Górny <mgorny@g.o> wrote:
3 >>
4 >> On Tue, 2020-05-26 at 20:24 -0700, Alec Warner wrote:
5 >> > The TL;DR is that a crack team of infra-folks[0] have been putting together
6 >> > demos of CI services and things like gitlab / gitea / gerrit and so on.
7 >> >
8 >> > Some of these come in combined (e.g. gitlab offers repo hosting, code
9 >> > review / pull reqs, CI services, and deploy services.) Some of these are
10 >> > piecemeal (e.g. gerrit has code review, zuul has CI) and gitea offers
11 >> > repo-hosting but CI is separate (e.g. drone.)
12 >> >
13 >> > On the infra-side, I think we are pretty happy with repo-hosting (gitolite)
14 >> > and repo-serving (gitweb). We are missing a CI piece and a pull-request
15 >> > piece. Most of the users using PRs use either a gitlab or github mirror.
16 >> >
17 >> > I think the value of CI is pretty obvious to me (and I see tons of use
18 >> > cases in Infra.) We could easily build CI into our current repository
19 >> > solution (e.g. gitolite.) However gitolite doesn't really support PRs in a
20 >> > uniform way and so CI is mostly for submitted code; similar to the existing
21 >> > ::gentoo repo CI offered by mgorny.
22 >> >
23 >> > If we build a code review solution (like gitea / gerrit) would people use
24 >> > it? Would you use it if you couldn't merge (because the code review
25 >> > solution can't gpg sign your commits or merges) so a tool like the existing
26 >> > pram tool would be needed to merge?
27 >> >
28 >>
29 >> Does GitLab count? Gerrit is just PITA. I think we had some concerns
30 >> about Gitea, so I'd like to test it before deciding. GitLab OTOH works
31 >> just fine for a lot of projects, and seems the next best thing after
32 >> GitHub
33 >
34 >
35 > Gitlab does count (we deployed and tested an onprem version.) I think there are some major issues with it though.
36 > - Licensing. Gitlab-CE is available, gitlab-EE is not OSS nor OSI approved and many of the features we need are EE only and are not available in CE.
37
38 It's very surprising to me that CE wouldn't work for our purposes.
39 Debian, GNOME, KDE, XFCE, and FreeDesktop have all switched to GitLab
40 and are using CE. It's hard to believe that Gentoo's usage or
41 requirements would be so different as to make GitLab a non-viable
42 option.
43
44 What features of EE do you think we need?

Replies