Gentoo Archives: gentoo-dev

From: Dan Armak <danarmak@g.o>
To: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] Proposed change to base.eclass: patch || die
Date: Sat, 06 Aug 2005 12:56:12
Message-Id: 200508061554.33817.danarmak@gentoo.org
In Reply to: Re: [gentoo-dev] Proposed change to base.eclass: patch || die by "Diego 'Flameeyes' Pettenò"
1 On Friday 05 August 2005 12:34, Diego 'Flameeyes' Pettenò wrote:
2 > On Friday 29 July 2005 15:56, Dan Armak wrote:
3 > > base.eclass (which inherited by many other eclasses) has an src_unpack
4 > > supporting patching from patchfiles listed in $PATCHES. However, today,
5 > > if patching fails the process doesn't abort.
6 >
7 > About this, there are still problems about committing a change on
8 > base.eclass to use epatch instead of patch? (so that it also takes care of
9 > recognize the right strip option)
10 I don't think there are any problems.
11
12 I've been using a modified base.eclass that died if patching failed for the
13 last few weeks, so I know the packages I have installed don't have failing
14 patches. Since this thread started I've modified it to use epatch and so far
15 that's worked OK.
16
17 So I think we can commit this (with epatch, that is). Can I consider the
18 thread so far a consensus to let me do it?
19
20 BTW, I've managed to lost all my mail from Thursday, so if there was something
21 relevant in this thread could someone please forward it to me.
22
23 --
24 Dan Armak
25 Gentoo Linux developer (KDE)
26 Public GPG key: http://dev.gentoo.org/~danarmak/danarmak-gpg-public.key
27 Fingerprint: DD70 DBF9 E3D4 6CB9 2FDD 0069 508D 9143 8D5F 8951