Gentoo Archives: gentoo-dev

From: David Seifert <soap@g.o>
To: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] [PATCH 1/1] docs.eclass: invert (B)DEPEND if condition
Date: Thu, 01 Jul 2021 08:13:25
Message-Id: 80eeafabea75f22e4abfe48da4bb1ed7d05d2c3c.camel@gentoo.org
In Reply to: [gentoo-dev] [PATCH 1/1] docs.eclass: invert (B)DEPEND if condition by Andrew Ammerlaan
1 On Thu, 2021-07-01 at 09:14 +0200, Andrew Ammerlaan wrote:
2 > As suggested by Soap (Thank You!)
3 >
4 > Makes this part more future proof, and removes the "," that shouldn't
5 > have been there.
6 >
7 > diff --git a/eclass/docs.eclass b/eclass/docs.eclass
8 > index f49c6aeab9d..684ab26919c 100644
9 > --- a/eclass/docs.eclass
10 > +++ b/eclass/docs.eclass
11 > @@ -378,7 +378,7 @@ case ${DOCS_BUILDER} in
12 >                 ;;
13 >   esac
14 >
15 > -if [[ ${EAPI} == [7,8] ]]; then
16 > +if [[ ${EAPI} != 6 ]]; then
17 >         BDEPEND+=" doc? ( ${DOCS_DEPEND} )"
18 >   else
19 >         DEPEND+=" doc? ( ${DOCS_DEPEND} )"
20 >
21
22 +1, go ahead and commit it