| 1 |
On 10:01 Sun 08 Mar , Donnie Berkholz wrote: |
| 2 |
> On 16:48 Sun 08 Mar , Ciaran McCreesh wrote: |
| 3 |
> > On Sun, 8 Mar 2009 09:42:29 -0700 |
| 4 |
> > Donnie Berkholz <dberkholz@g.o> wrote: |
| 5 |
> > > - I understand the reasoning for the SRC_CONFIGURE_WITH blah stuff. I |
| 6 |
> > > strongly oppose this implementation because it makes ebuilds less |
| 7 |
> > > like bash scripts that are easy to understand. Instead I suggest |
| 8 |
> > > extending use_with() and use_enable() to accept multiple sets of |
| 9 |
> > > arguments (alternately, making custom, similar functions that will |
| 10 |
> > > take multiple args). |
| 11 |
> > |
| 12 |
> > How would that work? I can't see an obvious way of doing it that isn't |
| 13 |
> > more or less as verbose as just using multiple calls. |
| 14 |
> |
| 15 |
> It would just eliminate all but one call to use_with(). Depending on how |
| 16 |
> many you've got, this can shorten things up a fair bit. Here's an |
| 17 |
> example: |
| 18 |
> |
| 19 |
> econf \ |
| 20 |
> $(use_with 'x X' 'foo libfoo' 'bar' 'python pygtk') |
| 21 |
> econf \ |
| 22 |
> $(use_with x X) \ |
| 23 |
> $(use_with foo libfoo) \ |
| 24 |
> $(use_with bar) \ |
| 25 |
> $(use_with python pygtk) |
| 26 |
|
| 27 |
And the straightforward evolution of this would be additional with() and |
| 28 |
enable() functions for mandatory support. I still find this more |
| 29 |
intuitive than the set of variables. |
| 30 |
|
| 31 |
econf \ |
| 32 |
$(use_with 'x X' 'foo libfoo' 'bar' 'python pygtk') \ |
| 33 |
$(with foo bar blah baz) \ |
| 34 |
$(enable bam paw tick) |
| 35 |
|
| 36 |
|
| 37 |
-- |
| 38 |
Thanks, |
| 39 |
Donnie |
| 40 |
|
| 41 |
Donnie Berkholz |
| 42 |
Developer, Gentoo Linux |
| 43 |
Blog: http://dberkholz.wordpress.com |
Archives