Gentoo Archives: gentoo-dev

From: Mike Frysinger <vapier@g.o>
To: gentoo-dev@l.g.o
Cc: Donnie Berkholz <dberkholz@g.o>, armin76@g.o
Subject: Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in net-p2p/deluge: ChangeLog deluge-0.5.6.2.ebuild deluge-0.5.6.1.ebuild
Date: Thu, 01 Nov 2007 06:24:46
Message-Id: 200711010222.03924.vapier@gentoo.org
In Reply to: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in net-p2p/deluge: ChangeLog deluge-0.5.6.2.ebuild deluge-0.5.6.1.ebuild by Donnie Berkholz
1 On Wednesday 31 October 2007, Donnie Berkholz wrote:
2 > On 15:38 Wed 31 Oct , Raul Porcel (armin76) wrote:
3 > > 1.1 net-p2p/deluge/deluge-0.5.6.2.ebuild
4 > >
5 > > file :
6 > > http://sources.gentoo.org/viewcvs.py/gentoo-x86/net-p2p/deluge/deluge-0.5
7 > >.6.2.ebuild?rev=1.1&view=markup plain:
8 > > http://sources.gentoo.org/viewcvs.py/gentoo-x86/net-p2p/deluge/deluge-0.5
9 > >.6.2.ebuild?rev=1.1&content-type=text/plain
10 > >
11 > > pkg_setup() {
12 > > if has_version "<dev-libs/boost-1.34" && \
13 > > ! built_with_use "dev-libs/boost" threads; then
14 > > eerror "dev-libs/boost has to be built with threads USE-flag."
15 > > die "Missing threads USE-flag for dev-libs/boost"
16 > > fi
17 > > }
18 > >
19 > > src_compile() {
20 > > filter-ldflags -Wl,--as-needed
21 > >
22 > > distutils_src_compile
23 > > }
24 >
25 > If you moved the filter-ldflags() call up to pkg_setup(), you could drop
26 > src_compile() altogether to clean up the ebuild a little.
27
28 a better idea is to fix the problem instead of ignoring it with filter-ldflags
29 -mike

Attachments

File name MIME type
signature.asc application/pgp-signature

Replies