| 1 |
Fabian Groffen schrieb: |
| 2 |
> On 09-09-2018 11:22:41 -0400, Richard Yao wrote: |
| 3 |
>> -Werror has caught bugs that could have resulted in data loss in ZFS in the past thanks to it being built in userspace as part of zdb. So it is useful for integrity too, not just security (although arguably, integrity is part of security). |
| 4 |
> |
| 5 |
> This is a misconception, as jer already pointed out. Instead: |
| 6 |
> |
| 7 |
> -Werror has forced you to take notice of problems that could have |
| 8 |
> resulted in data loss in ZFS ... |
| 9 |
|
| 10 |
But in general it doesn't say when or how the problems became acute. Assuming |
| 11 |
that the warning isn't bogus, it could have been the code relying on |
| 12 |
undefined behavior, and the compiler changing the semantics of such behavior, |
| 13 |
and introducing an accompanying warning at the same time. |
| 14 |
|
| 15 |
|
| 16 |
Best regards, |
| 17 |
Chí-Thanh Christopher Nguyễn |
Archives