Gentoo Archives: gentoo-dev

From: Mike Frysinger <vapier@g.o>
To: gentoo-dev@l.g.o
Cc: Donnie Berkholz <dberkholz@g.o>, hawking@g.o
Subject: Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in sys-auth/pam_chroot: ChangeLog pam_chroot-0.9.2.ebuild
Date: Mon, 01 Oct 2007 08:41:35
Message-Id: 200710010428.34835.vapier@gentoo.org
In Reply to: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in sys-auth/pam_chroot: ChangeLog pam_chroot-0.9.2.ebuild by Donnie Berkholz
1 On Monday 01 October 2007, Donnie Berkholz wrote:
2 > On 07:46 Mon 01 Oct , Ali Polatel (hawking) wrote:
3 > > 1.1 sys-auth/pam_chroot/pam_chroot-0.9.2.ebuild
4 > >
5 > > file :
6 > > http://sources.gentoo.org/viewcvs.py/gentoo-x86/sys-auth/pam_chroot/pam_c
7 > >hroot-0.9.2.ebuild?rev=1.1&view=markup plain:
8 > > http://sources.gentoo.org/viewcvs.py/gentoo-x86/sys-auth/pam_chroot/pam_c
9 > >hroot-0.9.2.ebuild?rev=1.1&content-type=text/plain
10 > >
11 > > LDFLAGS="$(raw-ldflags)" emake \
12 > > CC="$(tc-getCC)" LD="$(tc-getLD)" || die "emake failed"
13 >
14 > This reads really strangely to me. It's passing variables on both sides
15 > of emake. Generally one would just pick a side (afterwards) and add
16 > everything there.
17
18 while i cant speak for this case, make provides the ability to check for the
19 location of where a variable is defined and change behavior based on it ...
20 here, make would say LDFLAGS is in the environment while CC and LD were
21 defined on the command line ... see the $(origin) function
22
23 also, make changes behavior for setting of variables based on the origin of
24 definition ... the "=" and "+=" operators get ignored when the variable is on
25 the command line, but work when in the environment ... then again, makefiles
26 that get screwy based on this i think are broken in the first place and
27 should get fixed ...
28 -mike

Attachments

File name MIME type
signature.asc application/pgp-signature