Re: [gentoo-dev] [PATCH] skel.ebuild: Update comments for inherit, SLOT, KEYWORDS.

[William Hubbs]

On Sun, Dec 31, 2017 at 08:07:33PM +0100, Pacho Ramos wrote:
> El dom, 31-12-2017 a las 12:12 -0600, William Hubbs escribió:
> > On Sun, Dec 31, 2017 at 06:44:39PM +0100, Michał Górny wrote:
> > > W dniu nie, 31.12.2017 o godzinie 14∶31 +0100, użytkownik Ulrich Müller
> > > napisał:
> > > > epatch() is provided by epatch.eclass now. Also comment the inherit
> > > > line, since not every ebuild will use it.
> > > >
> > > > Empty SLOT doesn't disable slots, but is outright illegal in all EAPIs.
> > > > Similar for KEYWORDS="*", which isn't "deprecated" but invalid.
> > > > ---
> > > >  skel.ebuild | 9 ++++-----
> > > >  1 file changed, 4 insertions(+), 5 deletions(-)
> > > >
> > > > diff --git a/skel.ebuild b/skel.ebuild
> > > > index 7ac9dfb7d6d8..4c19b1de4cb8 100644
> > > > --- a/skel.ebuild
> > > > +++ b/skel.ebuild
> > > > @@ -13,9 +13,9 @@
> > > >  EAPI=6
> > > >
> > > >  # inherit lists eclasses to inherit functions from. For example, an
> > > > ebuild
> > > > -# that needs the epatch function from eutils.eclass won't work without
> > > > the
> > > > +# that needs the epatch function from epatch.eclass won't work without
> > > > the
> > > >  # following line:
> > > > -inherit eutils
> > > > +#inherit epatch
> > >
> > > Well, given that it's EAPI 6 and we do not want to encourage people to
> > > use epatch there, I would prefer if we replaced that example with
> > > something else. But it's just a wishful thinking here.
> >
> > +1, but I'm not going to suggest what to replace it with.
> >
> > William
>
> Why not eapply (and drop inherit then)? :/

Because that isn't the preferred way to apply patches since it requires
you to override src_prepare.

If the example was about how to apply patches, the correct way is to put
them in a PATCHES variable in global scope, but that's not the intent of
the example.

The intent is to show inheriting an eclass.

William