Gentoo Archives: gentoo-dev

From: Ulrich Mueller <ulm@g.o>
To: gentoo-dev@l.g.o
Cc: "Michał Górny" <mgorny@g.o>
Subject: Re: [gentoo-dev] [PATCH autotools-utils 1/4] Support installing default docs, similarly to EAPI4.
Date: Fri, 06 Jan 2012 23:16:39
Message-Id: 20231.32934.963157.916144@a1i15.kph.uni-mainz.de
In Reply to: [gentoo-dev] [PATCH autotools-utils 1/4] Support installing default docs, similarly to EAPI4. by "Michał Górny"
1 >>>>> On Fri, 6 Jan 2012, Micha³ Górny wrote:
2
3 > if [[ ${DOCS} ]]; then
4 > dodoc "${DOCS[@]}" || die "dodoc failed"
5 > + else
6 > + local f
7 > + # same list as in PMS
8 > + for f in README* ChangeLog AUTHORS NEWS TODO CHANGES \
9 > + THANKS BUGS FAQ CREDITS CHANGELOG; do
10 > + if [[ -s ${f} ]]; then
11 > + dodoc "${f}" || die "(default) dodoc ${f} failed"
12 > + fi
13 > + done
14 > fi
15
16 Why only "similarly to EAPI 4" and not identical with it? The latter
17 would follow the principle of least surprise.
18
19 Taken from _eapi4_src_install() in phase-helpers.sh:
20
21 if ! declare -p DOCS &>/dev/null ; then
22 local d
23 for d in README* ChangeLog AUTHORS NEWS TODO CHANGES \
24 THANKS BUGS FAQ CREDITS CHANGELOG ; do
25 [[ -s "${d}" ]] && dodoc "${d}"
26 done
27 elif [[ $(declare -p DOCS) == "declare -a "* ]] ; then
28 dodoc "${DOCS[@]}"
29 else
30 dodoc ${DOCS}
31 fi
32
33 Ulrich

Replies