| 1 |
On Thu, 13 Jun 2019 15:02:23 +0200 |
| 2 |
Michael Haubenwallner <haubi@g.o> wrote: |
| 3 |
|
| 4 |
> On 6/13/19 2:45 PM, James Le Cuirot wrote: |
| 5 |
> > On Thu, 13 Jun 2019 13:08:15 +0200 |
| 6 |
> > Michael Haubenwallner <haubi@g.o> wrote: |
| 7 |
> > |
| 8 |
> >> EAUTORECONF_DEPENDS is non-empty for ppc-aix and x86-winnt only. |
| 9 |
> >> Also, unset variable 'arch' after use. |
| 10 |
> >> --- |
| 11 |
> >> eclass/xorg-3.eclass | 3 ++- |
| 12 |
> >> 1 file changed, 2 insertions(+), 1 deletion(-) |
| 13 |
> >> |
| 14 |
> >> diff --git a/eclass/xorg-3.eclass b/eclass/xorg-3.eclass |
| 15 |
> >> index 6ac90a64d59..f135058fba6 100644 |
| 16 |
> >> --- a/eclass/xorg-3.eclass |
| 17 |
> >> +++ b/eclass/xorg-3.eclass |
| 18 |
> >> @@ -116,7 +116,8 @@ WANT_AUTOMAKE="latest" |
| 19 |
> >> for arch in ${XORG_EAUTORECONF_ARCHES}; do |
| 20 |
> >> EAUTORECONF_DEPENDS+=" ${arch}? ( ${EAUTORECONF_DEPEND} )" |
| 21 |
> >> done |
| 22 |
> >> -DEPEND+=" ${EAUTORECONF_DEPENDS}" |
| 23 |
> >> +unset arch |
| 24 |
> >> +BDEPEND+=" ${EAUTORECONF_DEPENDS}" |
| 25 |
> >> [[ ${XORG_EAUTORECONF} != no ]] && BDEPEND+=" ${EAUTORECONF_DEPEND}" |
| 26 |
> >> unset EAUTORECONF_DEPENDS |
| 27 |
> >> unset EAUTORECONF_DEPEND |
| 28 |
> > |
| 29 |
> > Apart from the unset, the comment doesn't seem to relate to the actual |
| 30 |
> > change? |
| 31 |
> |
| 32 |
> Agreed: The relation should become clear with 15 lines of context. |
| 33 |
> Or do you mean something else? |
| 34 |
|
| 35 |
Okay, I get it now. I was also slightly confused by the very similar |
| 36 |
variable names. |
| 37 |
|
| 38 |
-- |
| 39 |
James Le Cuirot (chewi) |
| 40 |
Gentoo Linux Developer |
Archives