Gentoo Archives: gentoo-dev

From: Michael Orlitzky <mjo@g.o>
To: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] Review: xemacs-packages-r1.eclass
Date: Mon, 03 Apr 2017 23:06:03
Message-Id: b988d7c3-57f1-e0e8-aeab-e5693b001a75@gentoo.org
In Reply to: [gentoo-dev] Review: xemacs-packages-r1.eclass by David Seifert
1 On 04/02/2017 05:05 AM, David Seifert wrote:
2 >
3 > [[ ${XEMACS_PKG_CAT} ]] || die "XEMACS_PKG_CAT was not defined before inheriting xemacs-packages-r1.eclass"
4 > case ${XEMACS_PKG_CAT} in
5 > standard|mule|contrib)
6 > ;;
7 > *)
8 > die "Unsupported package category in XEMACS_PKG_CAT"
9 > ;;
10 > esac
11
12
13 I think that the first check is redundant, but it isn't important if you
14 don't feel like changing it.
15
16 Elsewhere: quoting the variables when they're used would produce better
17 error messages if somebody puts something stupid in the variables.