| 1 |
On Mon, Apr 25, 2005 at 03:04:48AM +0200, Anders Rune Jensen wrote: |
| 2 |
> Let me first start by saying that committing straight to stable was |
| 3 |
> clearly a mistake. I can't help wonder why CVS would change patch files |
| 4 |
> (it probably doesn't know the difference between ordinary files and |
| 5 |
> patches) |
| 6 |
This is mostly an assumption here, as I don't know all of the details, |
| 7 |
but in the past I did run into problems with patches that dealt with |
| 8 |
the CVS keywords. You'd commit the patch, but doing so would change it, |
| 9 |
until you commited it with the -kb keyword option. |
| 10 |
|
| 11 |
> or why repoman doesn't catch something like this? CVS changing |
| 12 |
> files on commit goes against the whole "test before commit" mantra and |
| 13 |
> I'm probably not the first to have encountered this problem? |
| 14 |
You aren't the first no, but the solutions to it are limited: |
| 15 |
- teach developers to use -kb where they should |
| 16 |
- use an alternative keyword only for the gentoo-x86 module (some of |
| 17 |
the BSDs do this IIRC) - and turn off the normal keywords. |
| 18 |
- repoman checks might be very difficult to do, but it should be |
| 19 |
possible to at least have it do warnings if it finds CVS keywords |
| 20 |
that might be dangerous. |
| 21 |
|
| 22 |
-- |
| 23 |
Robin Hugh Johnson |
| 24 |
E-Mail : robbat2@××××××××××××××.net |
| 25 |
Home Page : http://www.orbis-terrarum.net/?l=people.robbat2 |
| 26 |
ICQ# : 30269588 or 41961639 |
| 27 |
GnuPG FP : 11AC BA4F 4778 E3F6 E4ED F38E B27B 944E 3488 4E85 |
Archives