Re: [gentoo-dev] [PATCH v2] distutils-r1.eclass: support nonfatal in test

[Michał Górny]

On Fri, 2023-01-06 at 00:20 +0000, alexey+gentoo@××××××××.org wrote:
> From: Alexey Sokolov <alexey+gentoo@××××××××.org>
>
> Rationale:
>
> src_test() {
>   virtx distutils-r1_src_test
> }
>
> If the test fails with "die", Xvfb keeps running forever; but it's
> cleaned up correctly with die -n
>
> Signed-off-by: Alexey Sokolov <alexey+gentoo@××××××××.org>
> ---
>  eclass/distutils-r1.eclass | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/eclass/distutils-r1.eclass b/eclass/distutils-r1.eclass
> index 371d52bcb7e..8896768d3ce 100644
> --- a/eclass/distutils-r1.eclass
> +++ b/eclass/distutils-r1.eclass
> @@ -1,4 +1,4 @@
> -# Copyright 1999-2022 Gentoo Authors
> +# Copyright 1999-2023 Gentoo Authors
>  # Distributed under the terms of the GNU General Public License v2
>
>  # @ECLASS: distutils-r1.eclass
> @@ -1559,7 +1559,7 @@ distutils-r1_python_test() {
>  	esac
>
>  	if [[ ${?} -ne 0 ]]; then
> -		die "Tests failed with ${EPYTHON}"
> +		die -n "Tests failed with ${EPYTHON}"
>  	fi
>  }
>

LGTM.  I need to think if we have any changes pending.

-- 
Best regards,
Michał Górny