Gentoo Archives: gentoo-dev

From: Marek Szuba <marecki@g.o>
To: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] [PATCH] lua.eclass: initial implementation
Date: Mon, 07 Sep 2020 14:27:49
Message-Id: 2381e4c9-7b69-c33a-7721-a2378b91ff57@gentoo.org
In Reply to: Re: [gentoo-dev] [PATCH] lua.eclass: initial implementation by David Seifert
1 On 2020-09-06 17:46, David Seifert wrote:
2
3 > Unfortunately we won't get around a single-r1-style eclass too. What
4 > about all those programs embedding a specific lua version as plugin
5 > architecture?
6
7 This is still very much on my to-do list, I simply figured it would make
8 it easier for everyone reviewing this to leave it until the next iteration.
9
10 > But the basic principles underlying your eclass
11 > are finally correct, unlike the previous lua.eclass attempt.
12
13 Thank you! Of course it would have been much more difficult to achieve
14 were it not for MichaƂ's work on python-r1.
15
16
17 On 2020-09-06 19:13, Azamat Hackimov wrote:
18
19 >> +# @ECLASS-VARIABLE: LUA
20 >> +# @DEFAULT_UNSET
21 >> +# @DESCRIPTION:
22 >> +# The absolute path to the current Lua interpreter. This variable is set
23 >> +# automatically in functions called by lua_foreach_impl().
24 >> +#
25 >> +# Example value:
26 >> +# @CODE
27 >> +# /usr/bin/lua5.1
28 >
29 > I think there also needs a LUAC variable that points to the current
30 > Lua compiler.
31
32 Possibly, then again I have begun to wonder if we even need LUA
33 itself... Moreover, there would be no LUAC were the eclass made to
34 support luajit.
35
36 I guess we'll see how many ebuilds actually need these once we have
37 begun porting them to lua.eclass.
38
39 > There needs a LUA_MAJOR_VERSION (V variable in lua.pc, i.e. 5.1, 5.2,
40 > 5.3) instead of full version (R variable in lua.pc, i.e 5.1.5, 5.2.4).
41 > Some obscure Lua packages are required to define V variable to work
42 > properly.
43
44 Nah, one can easily go from the full version to the ABI version
45 (<nitpick>LUA_MAJOR_VERSION would just be 5</nitpick) in an ebuild by
46 either removing the "lua" prefix from ELUA or using ver_cut on the
47 output of $(lua_get_version). I would rather have the eclass output more
48 information that the user can partly discard, than output less
49 information and run into problems with that one braindead package which
50 insists of being passed the full Lua version.
51
52 --
53 MS

Attachments

File name MIME type
signature.asc application/pgp-signature