Gentoo Archives: gentoo-dev

From: "Michał Górny" <mgorny@g.o>
To: gentoo-dev@l.g.o
Cc: python@g.o, "Michał Górny" <mgorny@g.o>
Subject: [gentoo-dev] [PATCH] distutils-r1.eclass: Pass --skip-build when installing
Date: Sun, 22 Mar 2020 05:57:45
Message-Id: 20200322055714.9328-1-mgorny@gentoo.org
Explicitly pass --skip-build in order to prevent distutils from
rebuilding files when installing.  This is especially relevant to some
packages that build extensions, and the extensions get built again
in src_install().

Technically, this can break some customized build systems that write
implementation-specific data into source directory, and right now
the implied rebuild caused it to be rewritten when installing.  With
this patch, the newest version of the file would be installed for all
interpreters.  I am not aware of any such packages, though.

Signed-off-by: Michał Górny <mgorny@g.o>
---
 eclass/distutils-r1.eclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/eclass/distutils-r1.eclass b/eclass/distutils-r1.eclass
index fd6c0193d12e..51e99a009df1 100644
--- a/eclass/distutils-r1.eclass
+++ b/eclass/distutils-r1.eclass
@@ -873,7 +873,7 @@ distutils-r1_python_install() {
 	local root=${D%/}/_${EPYTHON}
 	[[ ${DISTUTILS_SINGLE_IMPL} ]] && root=${D%/}
 
-	esetup.py install --root="${root}" "${args[@]}"
+	esetup.py install --skip-build --root="${root}" "${args[@]}"
 
 	local forbidden_package_names=( examples test tests .pytest_cache )
 	local p
-- 
2.25.2