Gentoo Archives: gentoo-dev

From: "Michał Górny" <mgorny@g.o>
To: gentoo-dev@l.g.o
Cc: python@g.o, Zac Medico <zmedico@g.o>
Subject: Re: [gentoo-dev] [PATCH] python-utils-r1.eclass: _python_impl_supported, forward compat
Date: Tue, 02 May 2017 19:02:15
Message-Id: 1493751705.1420.2.camel@gentoo.org
In Reply to: [gentoo-dev] [PATCH] python-utils-r1.eclass: _python_impl_supported, forward compat by Zac Medico
1 On wto, 2017-05-02 at 11:49 -0700, Zac Medico wrote:
2 > Add forward compatibility up to python3.9. It's helpful to allow some
3 > flexibility in ebuild PYTHON_COMPAT settings, for third-party
4 > repositories that may be used with multiple snapshots of the gentoo
5 > repository.
6 > ---
7 > eclass/python-utils-r1.eclass | 2 +-
8 > 1 file changed, 1 insertion(+), 1 deletion(-)
9 >
10 > diff --git a/eclass/python-utils-r1.eclass b/eclass/python-utils-r1.eclass
11 > index 66a359e..997a994 100644
12 > --- a/eclass/python-utils-r1.eclass
13 > +++ b/eclass/python-utils-r1.eclass
14 > @@ -70,7 +70,7 @@ _python_impl_supported() {
15 > python2_7|python3_[456]|jython2_7)
16 > return 0
17 > ;;
18 > - pypy1_[89]|pypy2_0|python2_[56]|python3_[123])
19 > + pypy1_[89]|pypy2_0|python2_[56]|python3_[123789])
20 > return 1
21 > ;;
22 > pypy|pypy3)
23
24 Sounds like a very bad idea. How can you even think of adding
25 an implementation if you don't know what the eclass API for it would be?
26
27 --
28 Best regards,
29 Michał Górny

Attachments

File name MIME type
signature.asc application/pgp-signature

Replies