| 1 |
On Wed, 2021-01-06 at 14:25 +0100, Ulrich Mueller wrote: |
| 2 |
> > > > > > On Tue, 05 Jan 2021, Michał Górny wrote: |
| 3 |
> |
| 4 |
> > + # check for the override |
| 5 |
> > + local override_name=${ACCT_USER_NAME^^} |
| 6 |
> > + local override_var=ACCT_USER_${override_name//-/_}_ID |
| 7 |
> |
| 8 |
> I wonder about this line. Both hyphen and underscore are valid |
| 9 |
> characters in user names. |
| 10 |
> |
| 11 |
> So, ACCT_USER_FOO_BAR_ID would override the id for both foo_bar and |
| 12 |
> foo-bar users. |
| 13 |
|
| 14 |
I don't think this is the problem we need to be worrying about. I mean, |
| 15 |
if someone actually created user identifiers that differ only be non- |
| 16 |
alnum characters, I think that'd the problem to tackle. |
| 17 |
|
| 18 |
-- |
| 19 |
Best regards, |
| 20 |
Michał Górny |
Archives