Gentoo Archives: gentoo-dev

From: Mike Gilbert <floppym@g.o>
To: Gentoo Dev <gentoo-dev@l.g.o>
Cc: "Mike Frysinger (vapier)" <vapier@g.o>, qa@g.o
Subject: Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in eclass: toolchain.eclass
Date: Tue, 10 Feb 2015 03:59:31
Message-Id: CAJ0EP42=hJ1h9Pc_ZYTMV9T772UC_njwhiWFrE1nxmFcsOv2hQ@mail.gmail.com
In Reply to: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in eclass: toolchain.eclass by "Michał Górny"
1 On Mon, Feb 9, 2015 at 6:40 AM, Michał Górny <mgorny@g.o> wrote:
2 > Dnia 2015-02-09, o godz. 20:05:07
3 > "Mike Frysinger (vapier)" <vapier@g.o> napisał(a):
4 >
5 >> vapier 15/02/09 20:05:07
6 >>
7 >> Modified: toolchain.eclass
8 >> Log:
9 >> use multislot for all cross-compilers and versions older than gcc-4.6
10 >>
11 >> Revision Changes Path
12 >> 1.650 eclass/toolchain.eclass
13 >>
14 >> file : http://sources.gentoo.org/viewvc.cgi/gentoo-x86/eclass/toolchain.eclass?rev=1.650&view=markup
15 >> plain: http://sources.gentoo.org/viewvc.cgi/gentoo-x86/eclass/toolchain.eclass?rev=1.650&content-type=text/plain
16 >> diff : http://sources.gentoo.org/viewvc.cgi/gentoo-x86/eclass/toolchain.eclass?r1=1.649&r2=1.650
17 >>
18 >> Index: toolchain.eclass
19 >> ===================================================================
20 >> RCS file: /var/cvsroot/gentoo-x86/eclass/toolchain.eclass,v
21 >> retrieving revision 1.649
22 >> retrieving revision 1.650
23 >> diff -u -r1.649 -r1.650
24 >> --- toolchain.eclass 5 Feb 2015 23:28:17 -0000 1.649
25 >> +++ toolchain.eclass 9 Feb 2015 20:05:07 -0000 1.650
26 >> @@ -1,6 +1,6 @@
27 >> # Copyright 1999-2015 Gentoo Foundation
28 >> # Distributed under the terms of the GNU General Public License v2
29 >> -# $Header: /var/cvsroot/gentoo-x86/eclass/toolchain.eclass,v 1.649 2015/02/05 23:28:17 blueness Exp $
30 >> +# $Header: /var/cvsroot/gentoo-x86/eclass/toolchain.eclass,v 1.650 2015/02/09 20:05:07 vapier Exp $
31 >>
32 >> # Maintainer: Toolchain Ninjas <toolchain@g.o>
33 >>
34 >> @@ -155,7 +155,7 @@
35 >> IUSE+=" ${IUSE_DEF[*]}"
36 >>
37 >> # Support upgrade paths here or people get pissed
38 >> -if use multislot ; then
39 >> +if ! tc_version_is_at_least 4.6 || is_crosscompile || use multislot ; then
40 >> SLOT="${GCC_CONFIG_VER}"
41 >> else
42 >> SLOT="${GCC_BRANCH_VER}"
43 >
44 > This breaks a few packages [1,2]. Please fix the breakage and run
45 > repoman next time.
46 >
47 > [1]:https://travis-ci.org/gentoo/gentoo-portage-rsync-mirror/jobs/50118225#L4304
48 > [2]:https://travis-ci.org/gentoo/gentoo-portage-rsync-mirror/jobs/50118228#L923
49 >
50
51 Why is this change being made in the first place? I see this slotting
52 change gcc and previously in binutils, with no explanation given.