Gentoo Archives: gentoo-dev

From: "Michał Górny" <mgorny@g.o>
To: "Robin H. Johnson" <robbat2@g.o>
Cc: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] [PATCH] metadata: add vcs tag
Date: Wed, 12 Oct 2016 16:52:18
Message-Id: 20161012185202.425233b7.mgorny@gentoo.org
In Reply to: [gentoo-dev] [PATCH] metadata: add vcs tag by "Robin H. Johnson"
1 On Wed, 12 Oct 2016 09:44:41 -0700
2 "Robin H. Johnson" <robbat2@g.o> wrote:
3
4 > Signed-off-by: Robin H. Johnson <robbat2@g.o>
5 > ---
6 > metadata.xsd | 4 ++++
7 > 1 file changed, 4 insertions(+)
8 >
9 > diff --git a/metadata.xsd b/metadata.xsd
10 > index cad8304..20423f8 100644
11 > --- a/metadata.xsd
12 > +++ b/metadata.xsd
13 > @@ -83,6 +83,10 @@
14 > <xs:selector xpath='doc'/>
15 > <xs:field xpath='@lang'/>
16 > </xs:unique>
17 > + <xs:unique name='upstreamVCSUniquityConstraint'>
18 > + <xs:selector xpath='vcs'/>
19 > + <xs:field xpath='@fake-only-once'/>
20 > + </xs:unique>
21
22 Is there a reason to disallow more than one occurrence of <vcs/>?
23
24 > </xs:element>
25 > <xs:element name='use' type='useType'>
26 > <xs:unique name='flagUniquityConstraint'>
27
28 You are missing actually adding the element... You just added
29 a constraint on a non-existing element.
30
31 --
32 Best regards,
33 Michał Górny
34 <http://dev.gentoo.org/~mgorny/>