Re: [gentoo-dev] [RFC] new vala.eclass

[Tomáš Chvátal]

2012/8/25 Alexandre Rostovtsev <tetromino@g.o>:
Hi man,

*snip*
>
> case "${EAPI:-0}" in
>         0|1|2)
>                 die "EAPI=${EAPI} is not supported"
>                 ;;
>         *)
>                 EXPORT_FUNCTIONS pkg_setup
>                 ;;
> esac

Any reson for not supporting ALL known eapis?

*snip*
>         if [[ -z "${VALA_API_VERSION}" ]]; then
>                 die "VALA_API_VERSION not set"
>         fi
You can use the && instead of conditional as you have longer lines in
the file anyway

*snip*
>         if ! [[ -d "${T}/pkgconfig" ]]; then
>                 mkdir "${T}/pkgconfig" || die "mkdir failed"
>         fi
Same as above

*snip*
>         local p
You should put the var defs on the top, I know this aint ansi C but i
found that we tend to loose the variable declarations in long run
otherwise.

Cheers

Tom