Gentoo Archives: gentoo-dev

From: hasufell <hasufell@g.o>
To: gentoo-dev@l.g.o
Cc: dlan@g.o
Subject: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in net-misc/megatools: ChangeLog megatools-1.9.92.ebuild metadata.xml Manifest
Date: Fri, 05 Sep 2014 12:57:41
Message-Id: 5409B335.8010006@gentoo.org
1 Yixun Lan (dlan):
2 >
3 > EAPI=5
4 >
5 > AUTOTOOLS_AUTORECONF=1
6 > AUTOTOOLS_IN_SOURCE_BUILD=1
7 > inherit autotools-utils
8 >
9 > DESCRIPTION="Command line tools and C library for accessing Mega cloud storage"
10 > HOMEPAGE="https://github.com/megous/megatools"
11 > SRC_URI="https://github.com/megous/${PN}/archive/${PV}.tar.gz -> ${P}.tar.gz"
12 >
13 > LICENSE="GPL-2"
14 > SLOT="0"
15 > KEYWORDS="~amd64 ~x86"
16 > IUSE="introspection doc"
17
18 Why not provide static-libs USE flag?
19
20 >
21 > DEPEND="dev-libs/glib:2
22 > dev-libs/openssl
23
24 openssl is missing slot 0 here which is the only slot providing headers.
25
26 > net-misc/curl
27 > sys-fs/fuse
28
29 Probably not really worth the work, but afais fuse is automagically, so
30 it could be made a USE flag after fixing the build system.
31
32 > doc? ( app-text/asciidoc )
33
34 asciidoc is not an RDEPEND
35
36 > "
37 > RDEPEND="${DEPEND}"
38
39 virtual/pkgconfig is missing from build-time dep (also not an RDEPEND)
40
41 >
42 > src_configure() {
43 > local myeconfargs=(
44 > --enable-shared
45 > --disable-maintainer-mode
46 > --disable-warnings
47 > --disable-static
48 > --disable-glibtest
49 > $(use_enable introspection)
50 > $(use_enable doc docs-build)
51 > )
52 > autotools-utils_src_configure
53 > }
54 >
55 >
56 >
57
58 Build fails here when doc USE flag is disabled.
59
60 make[2]: *** No rule to make target `megadf.1', needed by `all'. Stop.
61
62 I suggest to remove it and build docs unconditionally.