Gentoo Archives: gentoo-dev

From: "Michał Górny" <mgorny@g.o>
To: gentoo-dev@l.g.o
Cc: "Michał Górny" <mgorny@g.o>
Subject: [gentoo-dev] [PATCH 6/8] systemd.eclass: Sanitize insopts
Date: Fri, 08 Jun 2018 07:21:47
Message-Id: 20180608071916.25716-7-mgorny@gentoo.org
In Reply to: [gentoo-dev] [PATCH 0/8] insopts/exeopts sanitization by "Michał Górny"
1 Sanitize insopts when calling doins, in order to avoid prior insopts
2 calls accidentally affecting do*/new* functions defined by the eclass.
3 ---
4 eclass/systemd.eclass | 8 ++++++++
5 1 file changed, 8 insertions(+)
6
7 diff --git a/eclass/systemd.eclass b/eclass/systemd.eclass
8 index 6dda4353064a..3dfe633b42e6 100644
9 --- a/eclass/systemd.eclass
10 +++ b/eclass/systemd.eclass
11 @@ -151,6 +151,7 @@ systemd_dounit() {
12 debug-print-function ${FUNCNAME} "${@}"
13
14 (
15 + insopts
16 insinto "$(_systemd_get_systemunitdir)"
17 doins "${@}"
18 )
19 @@ -165,6 +166,7 @@ systemd_newunit() {
20 debug-print-function ${FUNCNAME} "${@}"
21
22 (
23 + insopts
24 insinto "$(_systemd_get_systemunitdir)"
25 newins "${@}"
26 )
27 @@ -179,6 +181,7 @@ systemd_douserunit() {
28 debug-print-function ${FUNCNAME} "${@}"
29
30 (
31 + insopts
32 insinto "$(_systemd_get_userunitdir)"
33 doins "${@}"
34 )
35 @@ -193,6 +196,7 @@ systemd_newuserunit() {
36 debug-print-function ${FUNCNAME} "${@}"
37
38 (
39 + insopts
40 insinto "$(_systemd_get_userunitdir)"
41 newins "${@}"
42 )
43 @@ -222,6 +226,7 @@ systemd_install_serviced() {
44 [[ ${service} == *.d ]] && die "Service must not have .d suffix"
45
46 (
47 + insopts
48 insinto /etc/systemd/system/"${service}".d
49 newins "${src}" 00gentoo.conf
50 )
51 @@ -241,6 +246,7 @@ systemd_dotmpfilesd() {
52 done
53
54 (
55 + insopts
56 insinto /usr/lib/tmpfiles.d/
57 doins "${@}"
58 )
59 @@ -258,6 +264,7 @@ systemd_newtmpfilesd() {
60 || die 'tmpfiles.d files need to have .conf suffix.'
61
62 (
63 + insopts
64 insinto /usr/lib/tmpfiles.d/
65 newins "${@}"
66 )
67 @@ -320,6 +327,7 @@ systemd_enable_ntpunit() {
68 done
69
70 (
71 + insopts
72 insinto "$(_systemd_get_utildir)"/ntp-units.d
73 doins "${T}"/${ntpunit_name}.list
74 )
75 --
76 2.18.0.rc1