Gentoo Archives: gentoo-dev

From: "Marty E. Plummer" <hanetzer@×××××××××.com>
To: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] [PATCH] freedict.eclass: rename dict.eclass, generalize
Date: Wed, 25 Apr 2018 06:16:14
Message-Id: 20180425061558.yfiabbxqu5vwssvg@proprietary-killer
In Reply to: Re: [gentoo-dev] [PATCH] freedict.eclass: rename dict.eclass, generalize by Ulrich Mueller
1 On Wed, Apr 25, 2018 at 07:28:12AM +0200, Ulrich Mueller wrote:
2 > >>>>> On Tue, 24 Apr 2018, Marty E Plummer wrote:
3 >
4 > > Reworked to be usable with app-dicts/dictd-* ebuilds to avoid code
5 > > duplication
6 >
7 > I don't see much code duplication there, so I think it would be
8 > cleaner to have a second eclass, rather than adding conditionals to
9 > the existing one.
10 >
11 I mean if you take into account app-dicts/dictd-* and freedict.eclass;
12 without the above pr (which I did originally have with a new eclass,
13 until I realized that app-text/dictd's conf file hardcodes /usr/lib/dict
14 anyways so the freedict dictionaries get [at least on amd64 and other
15 targets which use/will use lib64] installed outside of the search path
16 anyways) they are all almost entirely identical with the contents of
17 freedict.eclass.
18
19 Another thought I had was moving the src_install into dict.eclass and
20 have freedict inherit it, adding the differences.

Replies