Gentoo Archives: gentoo-dev

From: Emily Rowlands <emily.rowlands+gentoo@×××××××.org>
To: gentoo-dev@l.g.o
Cc: Mike Pagano <mpagano@g.o>, Manoj Gupta <manojgupta@××××××××.org>
Subject: Re: [gentoo-dev] [PATCH] kernel-2.eclass: fix minor OBOBJCOPY -> OBJCOPY typo
Date: Wed, 05 Jan 2022 18:55:38
Message-Id: 6b835a75-bd0d-63bb-45e5-4fb1cc72a1a2@mailbox.org
In Reply to: [gentoo-dev] [PATCH] kernel-2.eclass: fix minor OBOBJCOPY -> OBJCOPY typo by Adrian Ratiu
1 Hi,
2
3 I noticed that `NM=$(tc-getNM)` is duplicated in the changed line also,
4 can you fix this at the same time?
5
6 Thanks,
7 Emily
8
9 On 05/01/2022 15:59, Adrian Ratiu wrote:
10 > Fixes:55f5c68c01e791c7339144aadc1f20802791551e
11 > Suggested-by: Manoj Gupta <manojgupta@××××××××.org>
12 > Signed-off-by: Adrian Ratiu <adrian.ratiu@×××××××××.com>
13 > ---
14 > eclass/kernel-2.eclass | 2 +-
15 > 1 file changed, 1 insertion(+), 1 deletion(-)
16 >
17 > diff --git a/eclass/kernel-2.eclass b/eclass/kernel-2.eclass
18 > index 865c43d3153..d1784717e41 100644
19 > --- a/eclass/kernel-2.eclass
20 > +++ b/eclass/kernel-2.eclass
21 > @@ -692,7 +692,7 @@ env_setup_xmakeopts() {
22 > elif type -p ${CHOST}-ar >/dev/null; then
23 > xmakeopts="${xmakeopts} CROSS_COMPILE=${CHOST}-"
24 > fi
25 > - xmakeopts="${xmakeopts} HOSTCC=$(tc-getBUILD_CC) CC=$(tc-getCC) LD=$(tc-getLD) AR=$(tc-getAR) NM=$(tc-getNM) NM=$(tc-getNM) OBOBJCOPY=$(tc-getOBJCOPY) READELF=$(tc-getREADELF) STRIP=$(tc-getSTRIP)"
26 > + xmakeopts="${xmakeopts} HOSTCC=$(tc-getBUILD_CC) CC=$(tc-getCC) LD=$(tc-getLD) AR=$(tc-getAR) NM=$(tc-getNM) NM=$(tc-getNM) OBJCOPY=$(tc-getOBJCOPY) READELF=$(tc-getREADELF) STRIP=$(tc-getSTRIP)"
27 > export xmakeopts
28 > }
29 >

Replies